Uh oh!
There was an error while loading. Please reload this page.
lib: refactor crypto cipher/hash/curve getters - #10682
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Jan 8, 2017
MemberAuthor
Benchmark results: $ node benchmark/compare.js --old ./node-master --new ./node-refactored --filter get-ciphers crypto > compare-crypto.csv
$ cat compare-crypto.csv | Rscript benchmark/compare.R improvement significant p.value crypto/get-ciphers.js v="crypto" n=1 6.04 % * 0.02953932 crypto/get-ciphers.js v="crypto" n=5000 -0.75 % 0.66187606 crypto/get-ciphers.js v="tls" n=1 7.92 % * 0.02733195 crypto/get-ciphers.js v="tls" n=5000 1.18 % 0.48262097
$ |
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions
Trott
commented
Jan 8, 2017
MemberAuthor
Trott
commented
Jan 8, 2017
MemberAuthor
(CI is green.) |
jasnell
approved these changes
Jan 8, 2017
targos
approved these changes
Jan 8, 2017
jasnell pushed a commit
that referenced
this pull request
Jan 10, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: #10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
jasnell
commented
Jan 10, 2017
Member
Landed in 022b53c |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: nodejs#10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: nodejs#10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: nodejs#10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: nodejs#10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 8, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: #10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 9, 2017
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: #10682 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util.filterDuplicateStrings()to eliminate unusedcode paths
.indexOf()->.includes()in testChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto util test lib