Skip to content

v6.x: deps: cherry-pick baba152 from V8 upstream - #10689

Closed
targos wants to merge 1 commit into
nodejs:v6.x-stagingfrom
targos:fix-9175-v6
Closed

v6.x: deps: cherry-pick baba152 from V8 upstream#10689
targos wants to merge 1 commit into
nodejs:v6.x-stagingfrom
targos:fix-9175-v6

Conversation

@targos

Copy link
Copy Markdown
Member

Original commit message:

fix stepping out of across throwing.

R=jgruber@chromium.org
BUG=v8:5559

Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{#40549}

Fixes: #9175

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Original commit message:
fix stepping out of across throwing.
R=jgruber@chromium.org
BUG=v8:5559
Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{nodejs#40549}
Fixes: nodejs#9175
@targostargos added debugger v8 engine Issues and PRs related to the V8 dependency. labels Jan 8, 2017
@nodejs-github-botnodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 8, 2017
@targostargos changed the title deps: cherry-pick baba152 from V8 upstreamv6.x: deps: cherry-pick baba152 from V8 upstreamJan 9, 2017

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

Copy link
Copy Markdown
Member

jasnell pushed a commit that referenced this pull request Jan 10, 2017
Original commit message:
fix stepping out of across throwing.
R=jgruber@chromium.org
BUG=v8:5559
Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{#40549}
PR-URL: #10689Fixes: #9175
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in cf564d0

@jasnelljasnell closed this Jan 10, 2017
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Original commit message:
fix stepping out of across throwing.
R=jgruber@chromium.org
BUG=v8:5559
Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{#40549}
PR-URL: #10689Fixes: #9175
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Original commit message:
fix stepping out of across throwing.
R=jgruber@chromium.org
BUG=v8:5559
Review-Url: https://codereview.chromium.org/2445233004
Cr-Commit-Position: refs/heads/master@{#40549}
PR-URL: #10689Fixes: #9175
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mscdexmscdex mentioned this pull request Mar 21, 2017
@targos
targos deleted the fix-9175-v6 branch June 1, 2017 09:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@targos@mhdawson@jasnell@ofrobots@nodejs-github-bot