Skip to content

test: improve code in test-domain-multi - #10798

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:domain-multi
Closed

test: improve code in test-domain-multi#10798
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:domain-multi

Conversation

@edsadr

@edsadredsadr commented Jan 14, 2017

Copy link
Copy Markdown
Contributor
  • use common.mustCall to validate functions executions
  • remove unnecessary variables
  • remove unnecessary assertions
  • remove console.log and console.error
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 14, 2017
@mscdexmscdex added domain Issues and PRs related to the domain subsystem. and removed dont-land-on-v7.x labels Jan 14, 2017
thefourtheye
thefourtheye reviewed Jan 14, 2017
View reviewed changes
Comment threadtest/parallel/test-domain-multi.js Outdated

@thefourtheyethefourtheyeJan 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use common.fail here.

@edsadr
test: improve code in test-domain-multi
e16e262
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
@edsadr

edsadr commented Jan 15, 2017

Copy link
Copy Markdown
ContributorAuthor

thanks @thefourtheye , just implemented it

@santigimeno

santigimeno commented Jan 15, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5863/

@lpinca

lpinca commented Jan 17, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/5905/

@lpinca

lpinca commented Jan 17, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Windows failures seem unrelated to these changes.

lpinca pushed a commit that referenced this pull request Jan 17, 2017
@edsadr@lpinca
test: improve code in test-domain-multi
e050c34
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca

lpinca commented Jan 17, 2017

Copy link
Copy Markdown
Member

Landed in e050c34.

@lpincalpinca closed this Jan 17, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadrItalo A. Casas
test: improve code in test-domain-multi
4ee840b
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: nodejs#10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@edsadrItalo A. Casas
test: improve code in test-domain-multi
4f400a0
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: nodejs#10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr@targos
test: improve code in test-domain-multi
878a15d
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadrItalo A. Casas
test: improve code in test-domain-multi
b496374
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: nodejs#10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadrItalo A. Casas
test: improve code in test-domain-multi
388bf17
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: nodejs#10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr@jasnell
test: improve code in test-domain-multi
5294723
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr@jasnell
test: improve code in test-domain-multi
b70f977
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr@MylesBorins
test: improve code in test-domain-multi
a434f45
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr@MylesBorins
test: improve code in test-domain-multi
1b1ba74
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
PR-URL: #10798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
+1 more reviewer
@thefourtheyethefourtheyethefourtheye left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

domainIssues and PRs related to the domain subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edsadr@santigimeno@lpinca@jasnell@thefourtheye@mscdex@nodejs-github-bot