Uh oh!
There was an error while loading. Please reload this page.
Revert "doc: correct vcbuild options for windows testing" - #10839
Merged
Conversation
jasnell
approved these changes
Jan 16, 2017
evanlucas
approved these changes
Jan 19, 2017
addaleax
commented
Jan 21, 2017
Member
@gibfahn You self-assigned this … should we wait with landing this? |
gibfahnforce-pushed
the
revert-vcbuild-nosign
branch
from
January 21, 2017 12:03
940722e to
93c4820Comparegibfahn
commented
Jan 21, 2017
MemberAuthor
Landed in 93c4820 |
gibfahn
commented
Jan 21, 2017
MemberAuthor
@addaleax Thanks for reminding me! In general feel free to land stuff I've self-assigned, it's more to keep it on my list than anything else. |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
This reverts commit ed9b6c1. PR-URL: nodejs#10839 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
This reverts commit ed9b6c1. PR-URL: nodejs#10839 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ed9b6c1.
Basically #10686 shouldn't have landed in master, it was superseded by #10156. I've reopened #10686.
Checklist
Affected core subsystem(s)
doc
cc/ @MylesBorins@jasnell let me know if I'm doing this right, basically did a
git revert ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.