Uh oh!
There was an error while loading. Please reload this page.
test: increase coverage for URL.searchParams - #10952
Conversation
8d0ef6f to
c7f159aCompareThere was a problem hiding this comment.
Might be worth checking done here too.
c7f159a to
91ec5aaCompare
TimothyGu
left a comment
There was a problem hiding this comment.
Most of these tests were actually derived from W3C's web-platform-tests, so I'm sure they would appreciate these changes as well.
There was a problem hiding this comment.
Also useful might be making sure entries[Symbol.iterator]() === entries.
There was a problem hiding this comment.
You may also test calling entries.next again (to simulate overread).
There was a problem hiding this comment.
entries.next.call(undefined) should throw as well.
There was a problem hiding this comment.
This test seems to overlap with a series of similar, but more comprehensive tests in #10905. I'm fine with keeping it in this PR, but I'd prefer just dropping it here.
TimothyGu
commented
Jan 22, 2017
@TimothyGu Thank you for reviews. PTAL 9c326fe EDIT: I'll squash. |
9c326fe to
b031c07CompareTimothyGu
left a comment
There was a problem hiding this comment.
@abouthiroppy, this PR seems to stop working after ed0086f. Can you please rebase and make sure it works on master? Thanks.
b031c07 to
0626657Comparehiroppy
commented
Jan 29, 2017
@TimothyGu I rebased and confirmed that the test passed. Thanks. |
There was a problem hiding this comment.
Actually do you mind fixing this and in -values.js as well?
constURLSearchParams=require('url').URLSearchParams;There was a problem hiding this comment.
Thanks, I forgot to change it.
Improve coverage for entries, keys and values. Validation tests and exception tests are included.
0626657 to
189de74CompareTimothyGu
commented
Jan 29, 2017
TimothyGu
commented
Jan 29, 2017
Landed in e7f4825. |
PR-URL: #10952 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #10952 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* index: allow #fragments in PR URLs Also check tightened PR_RE against pathname * review: fix Metadata state operation E.g. nodejs/node#10952 * review: simplify Fixes creation * review: overhaul getCollaborators() - Make regex static and more concise - Iterate over RE.exec - Use Map * review: remove extra whitespace Fixes: #5 * review: only look for LGTMs in <p>'s Fixes: nodejs/node#10657
Add exceptions for all cases.
Add
entries,keysandvaluesfiles.(Validation tests and exception tests are included.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test