Uh oh!
There was an error while loading. Please reload this page.
tls_wrap: proxy handle methods in prototype - #1108
Conversation
Set proxied methods wrappers in `TLSWrap` prototype instead of doing it on every socket allocation. Should speed up things a bit and will certainly make heapsnapshot less verbose.
indutny
commented
Mar 9, 2015
cc @iojs/collaborators too |
indutny
commented
Mar 9, 2015
indutny
commented
Mar 9, 2015
CI: good |
There was a problem hiding this comment.
do we care about the extra performance lost to creating a closure and referring to the call as this._parent[name] instead of this._parent.<name>?
There was a problem hiding this comment.
Nope, it shouldn't be critical here.
trevnorris
commented
Mar 9, 2015
The change looks good. Just have a question. |
bnoordhuis
commented
Mar 9, 2015
I see there is one TLS test failing on Windows but I'm not sure if it's related to this change... |
rvagg
commented
Mar 9, 2015
3 failures on windows are persistent and I don't believe they are related to this |
bnoordhuis
commented
Mar 9, 2015
I checked previous runs and parallel/test-tls-over-http-tunnel seems to be failing consistently (and it's always the same 3 or 4 tests that fail.) LGTM then. |
Set proxied methods wrappers in `TLSWrap` prototype instead of doing it on every socket allocation. Should speed up things a bit and will certainly make heapsnapshot less verbose. PR-URL: #1108 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
indutny
commented
Mar 9, 2015
Landed in 8431fc5, thank you everyone! |
Set proxied methods wrappers in
TLSWrapprototype instead of doing iton every socket allocation. Should speed up things a bit and will
certainly make heapsnapshot less verbose.
cc @iojs/crypto