Skip to content

test: skip when openssl CLI doesn't exist - #11095

Closed
sotayamashita wants to merge 1 commit into
nodejs:masterfrom
sotayamashita:feature/test-openssl-cli
Closed

test: skip when openssl CLI doesn't exist#11095
sotayamashita wants to merge 1 commit into
nodejs:masterfrom
sotayamashita:feature/test-openssl-cli

Conversation

@sotayamashita

@sotayamashitasotayamashita commented Feb 1, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Affected core subsystem(s)

test

I fixed#9509.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 1, 2017
@mscdexmscdex added the tls Issues and PRs related to the tls subsystem. label Feb 1, 2017
sam-github
sam-github previously requested changes Feb 1, 2017
View reviewed changes

@sam-githubsam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message is ungrammatical, change to

test: check openssl-cli exists

or

test: skip when openssl CLI doesn't exist

@sotayamashita

sotayamashita commented Feb 1, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@sam-github I changed the commit message

@sotayamashitasotayamashita changed the title test: check openssl-cli is existtest: skip when openssl CLI doesn't existFeb 1, 2017
@hiroppy

hiroppy commented Feb 2, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6156/

@sotayamashita

sotayamashita commented Feb 2, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@abouthiroppy
I would appreciate if you could tell me how to pass the CI.
When I create a PR, should I run the CI ?

@hiroppy

hiroppy commented Feb 2, 2017

Copy link
Copy Markdown
Member

@sotayamashita I think these failures are not caused by code🙃 CC @nodejs/testing

@gibfahn

gibfahn commented Feb 2, 2017

Copy link
Copy Markdown
Member

@sotayamashita those look like infrastructure problems.

CI 2: https://ci.nodejs.org/job/node-test-commit/7616/

@sotayamashita

sotayamashita commented Feb 2, 2017

Copy link
Copy Markdown
ContributorAuthor

@gibfahn Thanks.

@sotayamashita

sotayamashita commented Feb 2, 2017

Copy link
Copy Markdown
ContributorAuthor

@sam-github I changed the commit message. Is it ok ?

@joaocgreis

joaocgreis commented Feb 2, 2017

Copy link
Copy Markdown
Member

Aborted CI, only arm-fanned was pending because of nodejs/build#611

mhdawson
mhdawson approved these changes Feb 3, 2017
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Feb 3, 2017

Copy link
Copy Markdown
Member

One more attempt at CI run: https://ci.nodejs.org/job/node-test-pull-request/6205/

@addaleax
addaleax dismissed sam-github’s stale reviewFebruary 4, 2017 06:03

requested changes have been made

addaleax
addaleax approved these changes Feb 4, 2017
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more CI attempt: https://ci.nodejs.org/job/node-test-commit/7674/

@jasnell

jasnell commented Feb 7, 2017

Copy link
Copy Markdown
Member

New CI since there's some red in that last run: https://ci.nodejs.org/job/node-test-pull-request/6273/

@gibfahn

gibfahn commented Feb 8, 2017

Copy link
Copy Markdown
Member

@sotayamashita

When I create a PR, should I run the CI ?

Sorry, didn't see this before. Only collaborators have the access to run jobs in the Jenkins CI (ci.nodejs.org). Someone should run the CI for you when you submit the PR, if they don't you can comment asking for it to be run.

As long as you've followed CONTRIBUTING.md and run make -j4 test before submitting, that should be all you need to do.

Once CI has been run, you can click on the link and see the results, if there are any failures that seem related to changes you made you can investigate (but they could also just be infrastructure issues).

In general if you're not sure about something, you can always ask.

@jasnell

jasnell commented Feb 11, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/6360/

@sam-github

sam-github commented Feb 13, 2017

Copy link
Copy Markdown
Contributor

Landed in 5ffb7d7

sam-github pushed a commit that referenced this pull request Feb 13, 2017
@sotayamashita@sam-github
test: skip when openssl CLI doesn't exist
5ffb7d7
PR-URL: #11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@sotayamashita
sotayamashita deleted the feature/test-openssl-cli branch February 14, 2017 05:38
@sotayamashitasotayamashita mentioned this pull request Feb 14, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@sotayamashitaItalo A. Casas
test: skip when openssl CLI doesn't exist
1085a46
PR-URL: nodejs#11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@italoacasasitaloacasas mentioned this pull request Feb 14, 2017
Merged
@jasnell

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

needs a backport PR to land on v4 or v6

@sotayamashita

sotayamashita commented Mar 8, 2017

Copy link
Copy Markdown
ContributorAuthor

@jasnell I would like to implement but I don not know hot to do it. Is there document ?

@jasnell

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

The process is fairly simple. To backport for v6, for instance, create a working branch off the v6-x-staging branch:

$ git checkout v6.x-staging
$ git checkout -b test-openssl-cli-v6-backport

Then cherry-pick the commit that landed in master

$ git cherry-pick 5ffb7d72bb6d8c827b66a337c3318e3ac9b3055e

You will see that there are a number of conflicts to be resolved. Make the necessary changes to fix those conflicts, then complete the cherry-pick using:

$ git add {the-files-that-were-changed}
$ git cherry-pick --continue

Push the branch to your fork on Github and open a new PR against v6.x-staging, indicating that this is a Backport of #11095.

Make sure to run make test and make lint.

@sotayamashita

sotayamashita commented Mar 8, 2017

Copy link
Copy Markdown
ContributorAuthor

@jasnell Thank you very much. I really appreciate your thoughtfulness.

@sotayamashitasotayamashita mentioned this pull request Apr 3, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@sotayamashita@MylesBorins
test: skip when openssl CLI doesn't exist
0695c09
Backport-PR-URL: #12173
PR-URL: #11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@sotayamashita@MylesBorins
test: skip when openssl CLI doesn't exist
f874256
Backport-PR-URL: #12173
PR-URL: #11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@sotayamashita@andrew749
test: skip when openssl CLI doesn't exist
5854fa3
Backport-PR-URL: nodejs/node#12173
PR-URL: nodejs/node#11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+5 more reviewers
@sam-githubsam-githubsam-github approved these changes
@thefourtheyethefourtheyethefourtheye approved these changes
@hiroppyhiroppyhiroppy approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test failures without openssl-cli

11 participants

@sotayamashita@hiroppy@gibfahn@joaocgreis@mhdawson@jasnell@sam-github@thefourtheye@addaleax@mscdex@nodejs-github-bot