Skip to content

stream: minor fix for ReadableState - #11139

Closed
cynron wants to merge 2 commits into
nodejs:masterfrom
cynron:master
Closed

stream: minor fix for ReadableState#11139
cynron wants to merge 2 commits into
nodejs:masterfrom
cynron:master

Conversation

@cynron

@cynroncynron commented Feb 3, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

  1. remove unused flag ranOut from ReadableState, ranOut had been unused since 0f8de5e

  2. fix the comments for flag sync of ReadableState.

Checklist
  • make -j4 test (UNIX) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • stream

Wang Xinyong added 2 commits February 3, 2017 14:31
Wang Xinyong
stream: remove unused ranOut from ReadableState
3a43698
flag `ranOut` became unused since 0f8de5e,
but 0f8de5e did not remove it.
Wang Xinyong
stream: fix comments for sync flag of ReadableState
5315409
It seems that the comments for sync flag of ReadableState is
copied from WritableState without modification.
@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Feb 3, 2017
@cynroncynron changed the title Minor fix for ReadableStatestream: minor fix for ReadableStateFeb 3, 2017
@addaleax

addaleax commented Feb 3, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/7647/

@jasnell

jasnell commented Feb 3, 2017

Copy link
Copy Markdown
Member

@nodejs/streams

@jasnell

jasnell commented Feb 3, 2017

Copy link
Copy Markdown
Member

Given that this removes a property, this is potentially semver-major. It shouldn't be, but we need to be certain.

@addaleaxaddaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 3, 2017
@mcollina

mcollina commented Feb 3, 2017

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/563/

@mcollina

mcollina commented Mar 3, 2017

Copy link
Copy Markdown
Member

I think we are going to release this as semver-minor in readable-stream. If that does not cause issues, we can release this as semver-minor also in Node.

ReadableState is undocumented atm.

@mcollina

mcollina commented Mar 3, 2017

Copy link
Copy Markdown
Member

Landed as 1004b9b and 202b07f

@mcollinamcollina closed this Mar 3, 2017
mcollina pushed a commit that referenced this pull request Mar 3, 2017
Wang Xinyong@mcollina
stream: remove unused ranOut from ReadableState
1004b9b
flag `ranOut` became unused since 0f8de5e,
but 0f8de5e did not remove it.
PR-URL: #11139
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
mcollina pushed a commit that referenced this pull request Mar 3, 2017
Wang Xinyong@mcollina
stream: fix comment for sync flag of ReadableState
202b07f
It seems that the comment for sync flag of ReadableState is
copied from WritableState without modification.
PR-URL: #11139
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

addaleax commented Mar 4, 2017

Copy link
Copy Markdown
Member

@mcollina Just ICYMI, our current policy is that at least 2 CTC members need to sign off on semver-major changes before landing them. I don’t think that’s a problem here because it’s not something that’s really covered by our API (as you pointed out)… I just added the label because, at least from Node’s perspective, I don’t think there’s a reason to not consider this semver-major.

@mcollina

mcollina commented Mar 4, 2017

Copy link
Copy Markdown
Member

Oh, I thought this was sitting there for a while, and just reduced the pull requests count by one.
Thanks for noting.

@jasnelljasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

semver-majorPRs that contain breaking changes and should be released in the next major version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cynron@addaleax@jasnell@mcollina@nodejs-github-bot