Skip to content

backport: Deprecate old debug protocol in docs - #11172

Closed
hybrist wants to merge 1 commit into
nodejs:v7.x-stagingfrom
hybrist:jk-backport-pr10320
Closed

backport: Deprecate old debug protocol in docs#11172
hybrist wants to merge 1 commit into
nodejs:v7.x-stagingfrom
hybrist:jk-backport-pr10320

Conversation

@hybrist

Copy link
Copy Markdown
Contributor

Original PR: #10320, the only conflict was the V8 protocol URL that changed in the meantime.

Due to changes in V8, the debug protocol will no longer work in Node.js
8.0.0. Note this in the documentation.

PR-URL: #10320
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added debugger doc Issues and PRs related to the documentations. labels Feb 4, 2017
@hybristhybrist mentioned this pull request Feb 4, 2017
2 tasks
@hybristhybrist changed the title Backport #10320 to 7.xbackport: deprecate debug protocol in docsFeb 4, 2017
@hybristhybrist changed the title backport: deprecate debug protocol in docsbackport: Deprecate old debug protocol in docsFeb 4, 2017
@italoacasas

Copy link
Copy Markdown

@jkrems can you rebase this please.

@hybrist
hybristforce-pushed the jk-backport-pr10320 branch 2 times, most recently from f2f0f00 to 6bed46eCompareFebruary 18, 2017 18:24
@hybrist

Copy link
Copy Markdown
ContributorAuthor

Re-applied the commit to the new 7.x-staging branch.

Due to changes in V8, the debug protocol will no longer work in Node.js
8.0.0. Note this in the documentation.
PR-URL: nodejs#10320
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@hybrist
hybristforce-pushed the jk-backport-pr10320 branch from 6bed46e to cd54e3eCompareMarch 20, 2017 19:03
@hybrist

Copy link
Copy Markdown
ContributorAuthor

Re-applied the commit to the new 7.x-staging branch.

@italoacasas

Copy link
Copy Markdown

Landed in staging

@hybrist
hybrist deleted the jk-backport-pr10320 branch March 21, 2017 16:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hybrist@italoacasas@nodejs-github-bot