Uh oh!
There was an error while loading. Please reload this page.
test: wrap callbacks in mustCall() for test-http-agent-destroyed-socket.js - #11201
test: wrap callbacks in mustCall() for test-http-agent-destroyed-socket.js #11201shubheksha wants to merge 2 commits into
Conversation
Wrap the callbacks which make assertions in common.mustcall() to ensure they are called
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green. Would prefer to not add the two new console.log() statements if there isn't a super-compelling reason to do so.
| request1.socket.destroy(); | ||
| response.once('close', function() { | ||
| console.log('called'); |
| process.nextTick(common.mustCall(function() { | ||
| // assert that the same socket was not assigned to request2, | ||
| // since it was destroyed. | ||
| console.log('called 2'); |
Trott
commented
Feb 6, 2017
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but it looks like one more could be added on line 47 (response.once('close').
Trott
commented
Feb 6, 2017
@cjihrig That callback does not execute at all when I run the test. (Should it? If so, I think there's a bug.) Perhaps it is there to either handle a race condition or else is platform-dependent? The big comment a few lines above it seems relevant. |
cjihrig
commented
Feb 7, 2017
Yea, that comment does seem relevant. It should be fine to leave line 47 alone since it might not execute. It seems less than ideal to have cases like that in our tests, but that has nothing to do with this PR. |
Trott
commented
Feb 7, 2017
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: #11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Feb 11, 2017
Landed in 3d2bd7a |
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: #11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: nodejs#11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: nodejs#11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 7, 2017
needs a backport PR to land in v6 or v4 |
Wrap the callbacks which make assertions in common.mustcall() to ensure they are called
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Tests for http