Skip to content

internal/util: use internal/errors.js - #11301

Closed
seppevs wants to merge 1 commit into
nodejs:masterfrom
seppevs:internal_util_use_internal_errors
Closed

internal/util: use internal/errors.js#11301
seppevs wants to merge 1 commit into
nodejs:masterfrom
seppevs:internal_util_use_internal_errors

Conversation

@seppevs

@seppevsseppevs commented Feb 10, 2017

Copy link
Copy Markdown
Contributor

Change internal/util.js so it makes use of the new internal/errors.js module.

See #11273 for more info.

cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

error

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module. labels Feb 10, 2017
@jasnelljasnell mentioned this pull request Feb 10, 2017
Closed
80 tasks
@seppevs
seppevsforce-pushed the internal_util_use_internal_errors branch from 42ca4c3 to 0cb54ecCompareFebruary 10, 2017 21:12
joyeecheung
joyeecheung reviewed Feb 11, 2017
View reviewed changes
Comment threadtest/parallel/test-internal-errors.js Outdated

@joyeecheungjoyeecheungFeb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation looks off here?

Comment threadtest/parallel/test-internal-errors.js Outdated

@joyeecheungjoyeecheungFeb 11, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@seppevsseppevsFeb 11, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joyeecheung: the indentation is suggested by the linter

@joyeecheungjoyeecheungFeb 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like the linter is OK with arguments not indented the same way, as long as it's indented? Anyway it doesn't need to be fixed, just a nit :D

@seppevsseppevsFeb 13, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the linter expects the identation to start at an exact position: the position where the parameters start on the previous line.

thefourtheye
thefourtheye reviewed Feb 12, 2017
View reviewed changes
Comment threadlib/internal/errors.js Outdated

@thefourtheyethefourtheyeFeb 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function should go to the top.

@seppevsseppevsFeb 13, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used @jasnell 's PR as an example: #11300

@joyeecheungjoyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017
@joyeecheung

joyeecheung commented Feb 15, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6427/

@jasnelljasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017
@jasnell

jasnell commented May 1, 2017

Copy link
Copy Markdown
Member

We're finally able to move forward on this, but it's going to need a rebase

@seppevs
seppevsforce-pushed the internal_util_use_internal_errors branch from 0cb54ec to 70f3091CompareMay 1, 2017 20:12
@seppevs

seppevs commented May 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Rebase done

@joyeecheung

joyeecheung commented May 2, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/7802/

@jasnell

jasnell commented May 2, 2017

Copy link
Copy Markdown
Member

@nodejs/ctc ... this is ready to go, but as a semver-major needs another CTC member to sign off

Trott
Trott approved these changes May 2, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo textual nits and assuming CI is green.

Comment threaddoc/api/errors.md Outdated

@TrottTrottMay 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please put a period at the end of the sentence.

Comment threadlib/internal/errors.js Outdated

@TrottTrottMay 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: openssl -> OpenSSL

@seppevs

seppevs commented May 3, 2017

Copy link
Copy Markdown
ContributorAuthor

Changes done

@seppevs
seppevsforce-pushed the internal_util_use_internal_errors branch from 70f3091 to 498b4b3CompareMay 3, 2017 06:55
@fhinkel

fhinkel commented May 23, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8257/

@Trott

Trott commented May 24, 2017

Copy link
Copy Markdown
Member

@jasnell Should the blocked label be removed?

@jasnelljasnell removed the blocked PRs that are blocked by other issues or PRs. label May 24, 2017
jasnell
jasnell reviewed May 24, 2017
View reviewed changes
Comment threadtest/parallel/test-internal-util-assertCrypto.js Outdated

@jasnelljasnellMay 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the object param... e.g.

common.expectsError({code: 'ERR_NO_CRYPTO',type: Error});

@tniessen

tniessen commented Jun 14, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@seppevs Please fix @jasnell's annotation (#11301 (comment)) and resolve the conflicts.

tniessen
tniessen requested changes Jun 14, 2017
View reviewed changes
Comment threaddoc/api/errors.md Outdated

@tniessentniessenJun 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt this to match the wording used in #13627 ("Used when an attempt is made...").

@seppevs

seppevs commented Jun 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Changes done

@seppevs
seppevsforce-pushed the internal_util_use_internal_errors branch from 498b4b3 to 812fb50CompareJune 15, 2017 12:59
tniessen
tniessen reviewed Jun 15, 2017
View reviewed changes
Comment threaddoc/api/errors.md Outdated

@tniessentniessenJun 15, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This should be wrapped at 80 characters. I will approve and start CI after this is fixed.

@seppevsseppevsJun 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@seppevs
seppevsforce-pushed the internal_util_use_internal_errors branch from 812fb50 to efddcf1CompareJune 15, 2017 13:16
@tniessen

tniessen commented Jun 15, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8677/

@tniessentniessen self-assigned this Jun 15, 2017
@tniessen

tniessen commented Jun 15, 2017

Copy link
Copy Markdown
Member

Landed in de4a749, thank you! 🎉

tniessen pushed a commit that referenced this pull request Jun 15, 2017
@seppevs@tniessen
internal/util: use internal/errors.js
de4a749
PR-URL: #11301
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <fhinkel@vt.edu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
@bradennapierbradennapier mentioned this pull request Nov 3, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@fhinkelfhinkelfhinkel approved these changes
@TrottTrottTrott approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+2 more reviewers
@thefourtheyethefourtheyethefourtheye left review comments
@hiroppyhiroppyhiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tniessentniessen

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.semver-majorPRs that contain breaking changes and should be released in the next major version.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@seppevs@joyeecheung@jasnell@fhinkel@Trott@tniessen@thefourtheye@hiroppy@nodejs-github-bot