Skip to content

Add Docker working group - #1134

Closed
pesho wants to merge 1 commit into
nodejs:v1.xfrom
pesho:patch-1
Closed

Add Docker working group#1134
pesho wants to merge 1 commit into
nodejs:v1.xfrom
pesho:patch-1

Conversation

@pesho

Copy link
Copy Markdown
Contributor

/cc @iojs/tc

This is a request to establish a separate Docker working group. This is work that is already being done, and until now has been listed as a responsibility of the Build group. All members of Build who are also currently active contributors to the Docker images (@pesho, @wblankenship) will be among the initial members of the new group.

List of initial members:

@hmalphettes
@jlmitch5
@pesho
@Starefossen
@wblankenship

Also, it would be good to create a new GitHub team (@iojs/docker) with the initial members listed above, and given rights to manage https://github.com/iojs/docker-iojs

Comment threadWORKING_GROUPS.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: can you wrap lines at 80 columns?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended, thanks.

@bnoordhuis

Copy link
Copy Markdown
Member

+1 FWIW.

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

@retrohacker

Copy link
Copy Markdown

👍

@chrisdickinson

Copy link
Copy Markdown
Contributor

LGTM, and thanks for your hard work!

@pesho

Copy link
Copy Markdown
ContributorAuthor

So what happened here, guys? This was discussed at #1187. Is there a verdict?

A new `Docker` working group is added to `WORKING_GROUPS.md`. Also, removed
the Docker images responsibility from the `Build` group's description.
@pesho

pesho commented Apr 1, 2015

Copy link
Copy Markdown
ContributorAuthor

Rebased and updated according to the changes in #1113

@Fishrock123

Copy link
Copy Markdown
Contributor

@rvagg I can't find the notes for this anywhere, shouldn't this still be tc-meeting?

@Fishrock123

Copy link
Copy Markdown
Contributor

Confirmed at today's TC (#1311) that it was approved.

@Fishrock123Fishrock123 added the meta Issues and PRs related to the general management of the project. label Apr 4, 2015
@Fishrock123

Copy link
Copy Markdown
Contributor

Taking final responsibility for this. It was discussed in #1187 but the notes have not yet been PR'd.

Also, it would be good to create a new GitHub team (@iojs/docker) with the initial members listed above, and given rights to manage https://github.com/iojs/docker-iojs

@mikeal can you do that?

Fishrock123 pushed a commit that referenced this pull request Apr 4, 2015
A new `Docker` working group is added to `WORKING_GROUPS.md`.
Also, removed the Docker images responsibility from the `Build`
group's description.
PR-URL: #1134
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123

Copy link
Copy Markdown
Contributor

Landed in 679596c - Thanks for all your work, terribly sorry for the delay. :|

@pesho

pesho commented Apr 4, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot @Fishrock123

Hoping to have a GitHub team for the WG soon as well (ping @mikeal@rvagg)

@retrohacker

Copy link
Copy Markdown

❤️ @Fishrock123

@Fishrock123Fishrock123 mentioned this pull request Apr 4, 2015
@mikeal

Copy link
Copy Markdown
Contributor

created docker team with list of members from the README.

@pesho

pesho commented Apr 6, 2015

Copy link
Copy Markdown
ContributorAuthor

@mikeal the team needs permissions for the docker-iojs repository. Also, @hmalphettes and @jlmitch5 should be added as members.

@rvagg

rvagg commented Apr 6, 2015

Copy link
Copy Markdown
Member

docker-iojs added to the team, invites are already out to the two additions, they need to be accepted first.

@pesho

pesho commented Apr 6, 2015

Copy link
Copy Markdown
ContributorAuthor

Great, thanks ❤️

@pesho
pesho deleted the patch-1 branch April 6, 2015 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@pesho@bnoordhuis@cjihrig@retrohacker@chrisdickinson@Fishrock123@mikeal@rvagg