Uh oh!
There was an error while loading. Please reload this page.
errors: port internal/buffer errors to internal/errors - #11341
Closed
bougarfaoui wants to merge 4 commits into
Closed
errors: port internal/buffer errors to internal/errors#11341bougarfaoui wants to merge 4 commits into
bougarfaoui wants to merge 4 commits into
Conversation
jasnell
requested changes
Feb 13, 2017
| const code = icu.icuErrName(result); | ||
| const err = new Error(`Unable to transcode Buffer [${code}]`); | ||
| const err = new errors.Error('ERR_UNABlE_TRNSC_BUFF', code); |
Member
There was a problem hiding this comment.
Also, it would be better to fully spell out transcode and buffer
bougarfaoui
commented
Feb 13, 2017
Author
@jasnell what do you mean by 'type in code...' |
80 tasks
joyeecheung
requested changes
Feb 14, 2017
joyeecheung
left a comment
Member
There was a problem hiding this comment.
This should break test-icu-transcode.js, the test needs to be updated.
joyeecheung
commented
Feb 15, 2017
Member
fhinkel
commented
Jun 7, 2017
Member
I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11273
cc @jasnell
Semver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, buffer