Skip to content

test: refactor test-dgram-membership - #11388

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:refac-member
Closed

test: refactor test-dgram-membership#11388
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:refac-member

Conversation

@Trott

@TrottTrott commented Feb 14, 2017

Copy link
Copy Markdown
Member
  • match full error message in assert.throws()
  • wrapped function -> .bind()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

@Trott
test: refactor test-dgram-membership
a8e16c0
* match full error message in assert.throws()
* wrapped function -> .bind()
@TrottTrott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Feb 14, 2017
@hiroppy

hiroppy commented Feb 15, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6421/

jasnell pushed a commit that referenced this pull request Feb 16, 2017
@Trott@jasnell
test: refactor test-dgram-membership
08f15d8
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Feb 16, 2017

Copy link
Copy Markdown
Member

Landed in 08f15d8

@jasnelljasnell closed this Feb 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
@TrottItalo A. Casas
test: refactor test-dgram-membership
795e0dd
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: nodejs#11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@TrottItalo A. Casas
test: refactor test-dgram-membership
5723087
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasasitaloacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott@jasnell
test: refactor test-dgram-membership
28d25fd
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott@jasnell
test: refactor test-dgram-membership
6d03af4
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott@MylesBorins
test: refactor test-dgram-membership
6677c11
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott@MylesBorins
test: refactor test-dgram-membership
f2fb414
* match full error message in assert.throws()
* wrapped function -> .bind()
PR-URL: #11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott
Trott deleted the refac-member branch January 13, 2022 22:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@hiroppyhiroppyhiroppy approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dgramIssues and PRs related to the dgram subsystem / UDP.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@hiroppy@jasnell@lpinca@targos@cjihrig@gibfahn