Uh oh!
There was an error while loading. Please reload this page.
errors, events: migrate to internal/errors.js - #11400
Conversation
- Replaced existing error messages with new error codes - Fix failing tests
Replaced functions to use arrow functions wherever possible
Replaced existing functions with arrow functions wherever possible
joyeecheung
commented
Feb 19, 2017
fhinkel
commented
May 23, 2017
@shubheksha Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be 1 commit, right?). Thanks! |
@shubheksha if you rebase I'll go ahead and land assuming the CI passes. |
mhdawson
commented
Jun 16, 2017
@shubheksha just wondering if you are going to be able to rebase this or need any help ? |
fhinkel
commented
Jun 28, 2017
I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed. |
refack
commented
Jul 19, 2017
I'll follow up |
refack
commented
Jul 19, 2017
I'll follow up |
mhdawson
commented
Aug 18, 2017
@refack what do you mean by "I'll follow up". Its been a while so I'm wondering what we should do with this one. |
BridgeAR
commented
Sep 8, 2017
Ping @refack |
BridgeAR
commented
Sep 23, 2017
Closing due to the long inactivity. @shubheksha if you would like to pursue this further, please feel free to leave a comment or to open a new PR! I am sorry this could not land as is and your contribution is highly appreciated nevertheless. |
Fixes#11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, events, test