Uh oh!
There was an error while loading. Please reload this page.
util: eliminate unecessary internal/util export - #11455
Conversation
The objectToString method was only being used in one place within internalUtil. It didn't make sense to have it as a separate exported mnethod.
jasnell
commented
Feb 18, 2017
targos
commented
Feb 18, 2017
#11128 uses |
jasnell
commented
Feb 18, 2017
hmm... could it not simply define it's own objectToString or use Object.prototype.toString() directly? |
jasnell
commented
Feb 18, 2017
(thanks for pointing that out, btw :-) ...) |
targos
commented
Feb 18, 2017
absolutely. /cc @joyeecheung |
targos
left a comment
There was a problem hiding this comment.
LGTM this function doesn't add much value
The reason to use |
jasnell
commented
Feb 19, 2017
hmm... I'll hold on this then. I've been thinking through a solution on trapping the instances of classes we depend on. I'll see if I can get that PR in later this week. |
jasnell
commented
Feb 23, 2017
I'm going to go ahead and close this without further action. There are other places where this function is looking to be used. |
The objectToString method was only being used in one place
within internalUtil. It didn't make sense to have it as
a separate exported mnethod.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
internal util