Skip to content

test: add two test cases for querystring - #11481

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test-querystring
Closed

test: add two test cases for querystring#11481
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:test-querystring

Conversation

@watilde

@watildewatilde commented Feb 21, 2017

Copy link
Copy Markdown
Member

This test will improve querystring coverage:

The following lines will be called with the cases:

Checklist
  • make -j4 test
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 21, 2017
@mscdexmscdex added the querystring Issues and PRs related to the built-in querystring module. label Feb 21, 2017
@mscdex

mscdex commented Feb 21, 2017

Copy link
Copy Markdown
Contributor

I think just using 'test' for the subsystem in the first line of the commit is enough, as no change to the actual querystring module is being made in this PR.

CI: https://ci.nodejs.org/job/node-test-pull-request/6530/

@watilde

watilde commented Feb 21, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Ahh ok, now the tagging rule becomes apparent to me. Thanks!
I will update the message, and also probably I should squash the commits into one commit.

@watilde
test: add two test cases for querystring
6913df6
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1
and the state machine finds an empty substring between separators,
it should return an empty object.
+ Test invalid encoded strings: If provided string is an invalid
encoded string in `query.parse`, it will not be encoded.
@mscdexmscdex changed the title test,querystring: improve querystring coverage to cover two more linestest: add two test cases for querystringFeb 21, 2017
jasnell pushed a commit that referenced this pull request Feb 24, 2017
@watilde@jasnell
test: add two test cases for querystring
dd2e135
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1
and the state machine finds an empty substring between separators,
it should return an empty object.
+ Test invalid encoded strings: If provided string is an invalid
encoded string in `query.parse`, it will not be encoded.
PR-URL: #11481
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Feb 24, 2017

Copy link
Copy Markdown
Member

@addaleax ... just fyi, I was landing this PR just as your review came in so you're not listed on the reviewers

@jasnell

jasnell commented Feb 24, 2017

Copy link
Copy Markdown
Member

Landed in dd2e135

@jasnelljasnell closed this Feb 24, 2017
@addaleax

addaleax commented Feb 24, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@jasnell guess what I was just going to push to master! 😄

@watilde
watilde deleted the test-querystring branch February 24, 2017 01:12
@italoacasas

italoacasas commented Feb 25, 2017

Copy link
Copy Markdown

not landing in v7.x-staging at the moment because one test is failing. Any plan to backport?

@jasnelljasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn

gibfahn commented Jun 17, 2017

Copy link
Copy Markdown
Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@watilde

watilde commented Jun 18, 2017

Copy link
Copy Markdown
MemberAuthor

Since this update was related to the breaking change of the querystring in v8.x, I replaced backport label with dont-land-on. Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

querystringIssues and PRs related to the built-in querystring module.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@watilde@mscdex@jasnell@addaleax@italoacasas@gibfahn@TimothyGu@cjihrig@nodejs-github-bot