Skip to content

url: use hasIntl instead of try-catch - #11571

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/url-hasIntl
Closed

url: use hasIntl instead of try-catch#11571
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/url-hasIntl

Conversation

@watilde

@watildewatilde commented Feb 27, 2017

Copy link
Copy Markdown
Member

Like the other lib codes, we should use process.binding('config').hasIntl instead of try-catch to make sure icu is bonded or not.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-botnodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Feb 27, 2017
@JacksonTian

JacksonTian commented Feb 27, 2017

Copy link
Copy Markdown
Contributor

LGTM

@TimothyGu

TimothyGu commented Feb 27, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Slight nit in commit message: IMO "internal modules" sounds better than "lib codes". Otherwise LGTM.

CI: https://ci.nodejs.org/job/node-test-pull-request/6593/

@gibfahn

gibfahn commented Feb 27, 2017

Copy link
Copy Markdown
Member

Not entirely sure what happened with linuxone in that last CI, rerunning:

CI 2: https://ci.nodejs.org/job/node-test-commit/8137/

EDIT: Passed on rerun

@watilde

watilde commented Feb 28, 2017

Copy link
Copy Markdown
MemberAuthor

I will update the commit message to replace lib codes with internal modules :)

@watilde
url: use hasIntl instead of try-catch
50e7e6e
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
@watilde

watilde commented Mar 3, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/6686/

jasnell pushed a commit that referenced this pull request Mar 4, 2017
@watilde@jasnell
url: use hasIntl instead of try-catch
cccc6d8
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: #11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
@jasnell

jasnell commented Mar 4, 2017

Copy link
Copy Markdown
Member

Landed in cccc6d8

@jasnelljasnell closed this Mar 4, 2017
@watilde
watilde deleted the feature/url-hasIntl branch March 4, 2017 16:15
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@watilde@addaleax
url: use hasIntl instead of try-catch
24e6fcc
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: #11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
@evanlucasevanlucas mentioned this pull request Mar 8, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@watilde@MylesBorins
url: use hasIntl instead of try-catch
e6c65b2
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: #11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@watilde@MylesBorins
url: use hasIntl instead of try-catch
6344997
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: #11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@watilde@andrew749
url: use hasIntl instead of try-catch
ae48e46
Like the other internal modules, we should use
`process.binding('config').hasIntl` instead of `try-catch`
to make sure `icu` is bonded or not.
PR-URL: nodejs/node#11571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@watilde@JacksonTian@TimothyGu@gibfahn@jasnell@addaleax@lpinca@cjihrig@MylesBorins@nodejs-github-bot