Uh oh!
There was an error while loading. Please reload this page.
test: apply strict mode in test-repl - #11575
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test.
Trott
commented
Feb 27, 2017
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/6598/ Doing it early in case this is some unexpected platform-specific thing... |
Trott
commented
Feb 27, 2017
MemberAuthor
Based in |
thefourtheye
approved these changes
Feb 27, 2017
santigimeno
approved these changes
Feb 27, 2017
evanlucas
approved these changes
Feb 27, 2017
cjihrig
approved these changes
Feb 27, 2017
jasnell
approved these changes
Feb 27, 2017
Trott
commented
Feb 27, 2017
MemberAuthor
addaleax
approved these changes
Mar 1, 2017
addaleax
commented
Mar 1, 2017
Member
Landed in f3b9a85 |
addaleax pushed a commit
that referenced
this pull request
Mar 1, 2017
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: #11575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Mar 5, 2017
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: #11575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Apr 17, 2017
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: #11575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: #11575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Strict mode for the test will not automatically enable strict mode in the REPL object. Enable strict mode in the test. PR-URL: nodejs/node#11575 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test repl