test: fix params in parallel/test-fs-null-bytes.js by vsemozhetbyt · Pull Request #11601 · nodejs/node

vsemozhetbyt · 2017-02-28T10:52:36Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

fs, test

parallel/test-fs-null-bytes.js tests fs.appendFile() and fs.writeFile() with wrong parameters scheme, i.e. without mandatory data parameter. This may be not very important for the test aim, but it makes it somehow compromised. This PR adds a simple data parameter to the 6 calls of these functions.

targos

LGTM. Can you add a Refs: line with the related issue URL?

vsemozhetbyt · 2017-02-28T11:57:23Z

@targos Added. Sorry, maybe I had to post 2 separate issues for these cases.

seishun

Please add an explanation to the commit message explaining the change.
Maybe someone has a better idea for the data than '1'. If not, feel free to ignore.

targos · 2017-02-28T13:14:55Z

@seishun what about 'data'?

seishun · 2017-02-28T13:18:18Z

@targos I think it's better to follow other tests. For example. test\parallel\test-fs-write-file-sync.js uses abc and 123.

vsemozhetbyt · 2017-02-28T17:25:06Z

@seishun Done.

seishun

Functions fs.appendFile() and fs.writeFile() were called without mandatory data parameter.

How about:

The functions fs.appendFile() and fs.writeFile() were called without the required data parameter.

Also is that how functions are usually referred to in commit messages, with empty brackets?

This PR adds a simple data parameter to 6 calls of these functions.

I don't think this line is necessary, but in any case commit messages don't usually refer to themselves as PRs.

vsemozhetbyt · 2017-02-28T17:39:53Z

@seishun Fixed. As for 'how functions are usually referred to in commit messages' — I don't know. I just followed STYLE_GUIDE here:

References to methods should be used with parenthesis: socket.end() instead of socket.end.

Tell me if I should change this here.

seishun · 2017-02-28T17:57:30Z

Agreed, let's keep the parentheses as-is.

Also, maybe "were being called" instead of "were called". And maybe "argument" instead of "parameter".

hiroppy · 2017-03-01T08:11:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6636/

vsemozhetbyt · 2017-03-03T01:50:52Z

Could this be landed, please?

seishun · 2017-03-03T13:44:12Z

@vsemozhetbyt One more thing. The first line is too long. How about replace "params" with "args"?

The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595

vsemozhetbyt · 2017-03-03T14:02:18Z

@seishun Done.

The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins · 2017-04-17T21:38:55Z

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

vsemozhetbyt · 2017-04-18T00:26:53Z

@MylesBorins #12477

The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 Backport-PR-URL: #12477 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: nodejs/node#11595 Backport-PR-URL: nodejs/node#12477 PR-URL: nodejs/node#11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 28, 2017

vsemozhetbyt mentioned this pull request Feb 28, 2017
Some possible bugs concerning fs.appendFile() and fs.writeFile() #11595
Closed

targos approved these changes Feb 28, 2017
View reviewed changes

seishun suggested changes Feb 28, 2017
View reviewed changes

mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Feb 28, 2017

seishun mentioned this pull request Feb 28, 2017
fs: don't conflate data and callback in fs.appendFile #11607
Closed
3 tasks

cjihrig approved these changes Feb 28, 2017
View reviewed changes

seishun approved these changes Feb 28, 2017
View reviewed changes

seishun suggested changes Feb 28, 2017
View reviewed changes

seishun approved these changes Feb 28, 2017
View reviewed changes

jasnell approved these changes Feb 28, 2017
View reviewed changes

hiroppy approved these changes Mar 1, 2017
View reviewed changes

test: fix args in parallel/test-fs-null-bytes.js
af652a6
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595

seishun merged commit c500b5a into nodejs:masterMar 3, 2017

vsemozhetbyt deleted the test-fs-null-bytes branch March 3, 2017 14:14

vsemozhetbyt mentioned this pull request Mar 3, 2017
fs: fix deoptimizing use of arguments#11678
Closed
3 tasks

evanlucas mentioned this pull request Mar 8, 2017
v7.7.2 proposal #11745
Merged

MylesBorins added the backport-requested-v6.x label Apr 17, 2017

vsemozhetbyt mentioned this pull request Apr 18, 2017
(v6.x backport) test: fix args in parallel/test-fs-null-bytes.js #12477
Closed
2 tasks

MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged

aliscco mentioned this pull request Nov 29, 2023
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#786
Open

aliscco mentioned this pull request May 15, 2024
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#1513
Open

Uh oh!

Uh oh!

Conversation

vsemozhetbyt commented Feb 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented Feb 28, 2017

Uh oh!

seishun left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Feb 28, 2017

Uh oh!

seishun commented Feb 28, 2017

Uh oh!

vsemozhetbyt commented Feb 28, 2017

Uh oh!

seishun left a comment

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented Feb 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seishun commented Feb 28, 2017

Uh oh!

hiroppy commented Mar 1, 2017

Uh oh!

vsemozhetbyt commented Mar 3, 2017

Uh oh!

seishun commented Mar 3, 2017

Uh oh!

vsemozhetbyt commented Mar 3, 2017

Uh oh!

MylesBorins commented Apr 17, 2017

Uh oh!

vsemozhetbyt commented Apr 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

vsemozhetbyt commented Feb 28, 2017•
edited
Loading

vsemozhetbyt commented Feb 28, 2017•
edited
Loading