Uh oh!
There was an error while loading. Please reload this page.
Cherrypicked commits from joyent/node - #1163
Closed
cjihrig wants to merge 4 commits into
Closed
Conversation
Make PACKAGEMAKER customizable because PackageMaker is not necessarily installed in /Developer on OSX anymore. PR-URL: nodejs/node-v0.x-archive#9377 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
This commit changes the Windows examples in path.markdown to correctly display '\\'. PR-URL: nodejs/node-v0.x-archive#9412 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Allows socket.remote* properties to still be accessed even after the socket is closed. Fixes: nodejs/node-v0.x-archive#9287 PR-URL: nodejs/node-v0.x-archive#9366 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs/node-v0.x-archive#8741 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
commented
Mar 16, 2015
Member
LGTM. 095ae0d looks like a semver-minor change. |
cjihrig
commented
Mar 16, 2015
ContributorAuthor
Right. I'll call it out in #1157 |
rvagg
commented
Mar 18, 2015
Member
sorry, I would have -1'd the PackageMaker path thing because (1) we're not using it and (2) we're going to ditch PackageMaker entirely as soon as I get my act in to gear with #776, but that's no big deal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for more detail