Skip to content

doc: add Daijiro Wachi to collaborators - #11676

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:add-new-collaborator
Closed

doc: add Daijiro Wachi to collaborators#11676
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:add-new-collaborator

Conversation

@watilde

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 3, 2017
@watilde

Copy link
Copy Markdown
MemberAuthor

@evanlucasevanlucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome aboard!

@watilde

Copy link
Copy Markdown
MemberAuthor

Landed 4cb9f4f

@watildewatilde closed this Mar 3, 2017
@watilde
watilde deleted the add-new-collaborator branch March 3, 2017 17:23
watilde added a commit that referenced this pull request Mar 3, 2017
PR-URL: #11676
Reviewed-By: Evan Lucas <evanlucas@me.com>
@hiroppy

Copy link
Copy Markdown
Member

Welcome!!!

addaleax pushed a commit that referenced this pull request Mar 5, 2017
PR-URL: #11676
Reviewed-By: Evan Lucas <evanlucas@me.com>
@evanlucasevanlucas mentioned this pull request Mar 8, 2017
evanlucas added a commit that referenced this pull request Mar 8, 2017
Notable changes:
* doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) #11676
* tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) #7360
* util: fix inspecting symbol key in string (Ali BARIN) #11672
PR-URL: #11745
evanlucas added a commit that referenced this pull request Mar 8, 2017
Notable changes:
* doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) #11676
* tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) #7360
* util: fix inspecting symbol key in string (Ali BARIN) #11672
PR-URL: #11745
@italoacasasitaloacasas mentioned this pull request Mar 14, 2017
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 16, 2017
 Notable changes:
* doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs/node#11676
* tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs/node#7360
* util: fix inspecting symbol key in string (Ali BARIN) nodejs/node#11672
PR-URL: nodejs/node#11745
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Notable changes:
* doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs#11676
* tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs#7360
* util: fix inspecting symbol key in string (Ali BARIN) nodejs#11672
PR-URL: nodejs#11745
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
PR-URL: #11676
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins

Copy link
Copy Markdown
Contributor

A++. Glad to backport. Welcome to v6.x 😄

MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #11676
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#11676
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@watilde@hiroppy@MylesBorins@evanlucas@nodejs-github-bot