Skip to content

linkedlist: remove unused methods - #11726

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:linkedlist-remove-unused-methods
Closed

linkedlist: remove unused methods#11726
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:linkedlist-remove-unused-methods

Conversation

@mscdex

@mscdexmscdex commented Mar 7, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

This should probably only land once lib/_linklist.js is removed to avoid any breakage. Since that private module has been (runtime) deprecated since v5.0.0, should it finally be removed in v8.0.0? If not, I can mark this as 'in progress' or similar until it is removed. Thoughts @nodejs/ctc?

CI: https://ci.nodejs.org/job/node-test-pull-request/6736/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • lib/src

@mscdexmscdex added lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 7, 2017
@nodejs-github-botnodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 7, 2017
@mscdexmscdex removed the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Mar 7, 2017
indutny
indutny approved these changes Mar 7, 2017
View reviewed changes

@indutnyindutny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as CI is happy.

@sam-github

sam-github commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

I think the entire module should be removed, as you say, its been runtime deprecated since 5.x, 8.x is a good time to remove it.

@jasnell

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

@ChALkeR ... can you check to see if there is any ecosystem usage of _linked_list remaining? I'm +1 to removing it so long as it doesn't break anything (keeping in mind, of course, the fact that a stub should remain in order to keep malicious userland folks from jumping on the name)

@ChALkeR
ChALkeR self-requested a review March 8, 2017 13:46
@TrottTrott mentioned this pull request Mar 13, 2017
Closed
cjihrig
cjihrig approved these changes Mar 13, 2017
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the ecosystem is not using it. I'd also be +1 to removing it completely if it's not being used.

@mscdexmscdex added this to the 8.0.0 milestone Mar 14, 2017
@TrottTrott mentioned this pull request Mar 20, 2017
Closed
@mscdex

mscdex commented Mar 21, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@ChALkeR Any news?

CITGM FWIW: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/666/

@rvagg

rvagg commented Mar 22, 2017

Copy link
Copy Markdown
Member

lgtm

@mscdex

mscdex commented Mar 22, 2017

Copy link
Copy Markdown
ContributorAuthor

To those who approved this.... is that an approval of this PR as-is or approval of just removing the module entirely? @indutny@cjihrig@jasnell@rvagg

@jasnell

jasnell commented Mar 22, 2017 via email

Copy link
Copy Markdown
Member

@cjihrig

cjihrig commented Mar 22, 2017

Copy link
Copy Markdown
Contributor

What @jasnell said.

@TrottTrott mentioned this pull request Mar 26, 2017
Closed
@mscdex

mscdex commented Mar 29, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I've decided to do the _linklist removal separately in #12113. I can combine these two if there is interest in doing so.

@TrottTrott mentioned this pull request Apr 3, 2017
Closed
jasnell pushed a commit that referenced this pull request Apr 4, 2017
@mscdex@jasnell
linkedlist: remove unused methods
b40dab5
PR-URL: #11726
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@jasnell

jasnell commented Apr 4, 2017

Copy link
Copy Markdown
Member

Landed in b40dab5

@jasnelljasnell closed this Apr 4, 2017
@mscdex
mscdex deleted the linkedlist-remove-unused-methods branch April 4, 2017 20:09
@jasnelljasnell mentioned this pull request Apr 4, 2017
Closed
@yosuke-furukawayosuke-furukawa mentioned this pull request May 4, 2017
Closed
2 tasks
@ChALkeR

ChALkeR commented May 4, 2017

Copy link
Copy Markdown
Member

Sorry, it looks like I forgot this one.

It's completely ok to change, the public version of the module have been runtime-deprecated in #3078 and removed in #12113. The (old) usage data is at #3078 (comment) and was about 17 packages.

ChALkeR
ChALkeR reviewed May 4, 2017
View reviewed changes

@ChALkeRChALkeR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@indutnyindutnyindutny approved these changes
@thefourtheyethefourtheyethefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mscdex@sam-github@jasnell@rvagg@cjihrig@ChALkeR@indutny@thefourtheye@Trott@nodejs-github-bot