Uh oh!
There was an error while loading. Please reload this page.
doc: fix a typo in api/process.md - #11780
Closed
sabakugaara wants to merge 1 commit into
Closed
Conversation
aqrln
commented
Mar 10, 2017
Contributor
It actually doesn't. The first line of the commit message should not exceed 50 characters. I'd suggest to reword it to something like |
sabakugaaraforce-pushed
the
events-typo-for-process
branch
from
March 10, 2017 03:19
66da4f4 to
ee10e6eComparesabakugaara
commented
Mar 10, 2017
ContributorAuthor
Thanks! |
sabakugaaraforce-pushed
the
events-typo-for-process
branch
from
March 10, 2017 03:26
ee10e6e to
8b23adfCompareContributor
@sabakugaara glad to help :) I'd also suggest you to make your full commit message more explicit because it isn't very clear, to be honest. How about this? Feel free to reword it as you like. |
jasnell
approved these changes
Mar 10, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`.
sabakugaaraforce-pushed
the
events-typo-for-process
branch
from
March 10, 2017 05:31
8b23adf to
05300e0Comparelpinca
approved these changes
Mar 10, 2017
cjihrig
approved these changes
Mar 10, 2017
jasnell pushed a commit
that referenced
this pull request
Mar 15, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: #11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Mar 15, 2017
Member
Landed in 27f4c94 |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 20, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: nodejs#11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jungx098 pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: nodejs#11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: #11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: #11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: nodejs/node#11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Mar 7, 2020
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
In process
warningevent sample code, it should beevents.defaultMaxListeners