Skip to content

net: remove an unused internal module assertPort - #11812

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/assertPort
Closed

net: remove an unused internal module assertPort#11812
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/assertPort

Conversation

@watilde

@watildewatilde commented Mar 12, 2017

Copy link
Copy Markdown
Member

Since a module assertPort in lib/internal/net.js is not used anymore, we can remove it. The coverage of lib/internal/net.js will be 100% with this.

See also: #11667

Checklist
  • make -j4 test
  • commit message follows commit guidelines
Affected core subsystem(s)

net

@watilde
net: remove an unused internal module assertPort
23587b6
A module `assertPort` in `lib/internal/net.js` is not used anymore.
Refs: nodejs#11667
@nodejs-github-botnodejs-github-bot added the net Issues and PRs related to the net subsystem. label Mar 12, 2017
@JacksonTian

JacksonTian commented Mar 12, 2017

Copy link
Copy Markdown
Contributor

LGTM

@mscdex

mscdex commented Mar 12, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6812/

@watilde

watilde commented Mar 13, 2017

Copy link
Copy Markdown
MemberAuthor

Probably, the CI errors caused by the same reason with this: #11817 (comment). I will retry it.

@watilde

watilde commented Mar 13, 2017

Copy link
Copy Markdown
MemberAuthor

New CI: https://ci.nodejs.org/job/node-test-pull-request/6826/

@watildewatilde mentioned this pull request Mar 13, 2017
Closed
3 tasks
@watilde

watilde commented Mar 14, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 879d666

@watildewatilde closed this Mar 14, 2017
@watilde
watilde deleted the feature/assertPort branch March 14, 2017 17:57
watilde added a commit that referenced this pull request Mar 14, 2017
@watilde
net: remove an unused internal module assertPort
879d666
A module `assertPort` in `lib/internal/net.js` is not used anymore.
Refs: #11667
PR-URL: #11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@watilde@jungx098
net: remove an unused internal module assertPort
7f8cd16
A module `assertPort` in `lib/internal/net.js` is not used anymore.
Refs: nodejs#11667
PR-URL: nodejs#11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@italoacasas

italoacasas commented Mar 21, 2017

Copy link
Copy Markdown

This PR needs backport to v7

@jasnelljasnell mentioned this pull request Apr 4, 2017
Closed
watilde added a commit to watilde/node that referenced this pull request May 5, 2017
@watilde
net: remove an unused internal module assertPort
acb77f3
A module `assertPort` in `lib/internal/net.js` is not used anymore.
Refs: nodejs#11667
PR-URL: nodejs#11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@watildewatilde mentioned this pull request May 5, 2017
Closed
2 tasks
watilde added a commit that referenced this pull request May 12, 2017
@watilde
net: remove an unused internal module assertPort
33ea7a2
A module `assertPort` in `lib/internal/net.js` is not used anymore.
Refs: #11667
PR-URL: #11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn

gibfahn commented Jun 17, 2017

Copy link
Copy Markdown
Member

@watilde should this be backported to v6.x? 33ea7a2 applies cleanly, so if it should I'll cherry-pick it directly.

@MylesBorins

MylesBorins commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

ping @watilde

1 similar comment
@MylesBorins

MylesBorins commented Aug 14, 2017

Copy link
Copy Markdown
Contributor

ping @watilde

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@evanlucasevanlucasevanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

14 participants

@watilde@JacksonTian@mscdex@italoacasas@gibfahn@MylesBorins@jasnell@evanlucas@addaleax@lpinca@targos@cjihrig@joyeecheung@nodejs-github-bot