Skip to content

test: add regex to assert.throws in test-vm-run-in-new-context - #11815

Closed
matejkrajcovic wants to merge 1 commit into
nodejs:masterfrom
matejkrajcovic:fix-test
Closed

test: add regex to assert.throws in test-vm-run-in-new-context#11815
matejkrajcovic wants to merge 1 commit into
nodejs:masterfrom
matejkrajcovic:fix-test

Conversation

@matejkrajcovic

@matejkrajcovicmatejkrajcovic commented Mar 12, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@matejkrajcovic
test: add regex to assert.throws
2e10483
Make sure test matches this specific error message.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 12, 2017
@mscdexmscdex added the vm Issues and PRs related to the vm subsystem. label Mar 12, 2017
@mscdex

mscdex commented Mar 12, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6811/

jasnell pushed a commit that referenced this pull request Mar 15, 2017
@matejkrajcovic@jasnell
test: add regex to assert.throws
2281944
Make sure test matches this specific error message.
PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Mar 15, 2017

Copy link
Copy Markdown
Member

Landed in 2281944

@jasnelljasnell closed this Mar 15, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@matejkrajcovicItalo A. Casas
test: add regex to assert.throws
c9cf922
Make sure test matches this specific error message.
PR-URL: nodejs#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasasitaloacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@matejkrajcovic@jungx098
test: add regex to assert.throws
39e47f6
Make sure test matches this specific error message.
PR-URL: nodejs#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@matejkrajcovic@MylesBorins
test: add regex to assert.throws
bde2f16
Make sure test matches this specific error message.
PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@matejkrajcovic@MylesBorins
test: add regex to assert.throws
a3f327f
Make sure test matches this specific error message.
PR-URL: #11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
@matejkrajcovic
matejkrajcovic deleted the fix-test branch May 7, 2017 20:56
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@matejkrajcovic@andrew749
test: add regex to assert.throws
c521c1a
Make sure test matches this specific error message.
PR-URL: nodejs/node#11815
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@hiroppyhiroppyhiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@matejkrajcovic@mscdex@jasnell@addaleax@lpinca@cjihrig@hiroppy@MylesBorins@nodejs-github-bot