Uh oh!
There was an error while loading. Please reload this page.
test: test various calling patterns of net.connect() related functions - #11847
test: test various calling patterns of net.connect() related functions#11847joyeecheung wants to merge 5 commits into
Conversation
92d8243 to
44a1b04Compare44a1b04 to
8d6ee2cComparejoyeecheung
commented
Mar 15, 2017
Error messages vary on different machines..loosen up the message validation and try again. CI: https://ci.nodejs.org/job/node-test-pull-request/6850/ |
046cc82 to
969e285Compared2d8b48 to
40e984dComparejoyeecheung
commented
Mar 16, 2017
Something is wrong with @jasnell PTAL, thanks. CI is green now: https://ci.nodejs.org/job/node-test-pull-request/6867/ |
jasnell
commented
Mar 16, 2017
Still LGTM! |
PR-URL: #11847 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 16, 2017
Landed in 7b830f4 |
PR-URL: nodejs#11847 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
commented
Mar 21, 2017
This PR need backport to v7 |
gibfahn
commented
Jun 18, 2017
@joyeecheung Should this be backported to If it is backported, the PR should include #12601. |
Related: #11761
This PR adds coverage to more calling patterns of
net.connect:net.connect(),net.createConnection(),new Socket().connect()with/without callback, withportpassed in plain argument/in optiontest-net-create-connection.jsand rename it totest-net-connect-options-port.jsconnect(path)test-net-connect-options.js, add tests for morenew Socket()options.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, net