Skip to content

doc: require uses fs root for '/' prefix - #11897

Closed
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:require-path-doc
Closed

doc: require uses fs root for '/' prefix#11897
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:require-path-doc

Conversation

@bmeck

@bmeckbmeck commented Mar 17, 2017

Copy link
Copy Markdown
Member

Fixes: #7151

Checklist
Affected core subsystem(s)

doc

@bmeckbmeck added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 17, 2017
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 17, 2017
@bmeckbmeck mentioned this pull request Mar 17, 2017
Closed
vsemozhetbyt
vsemozhetbyt reviewed Mar 17, 2017
View reviewed changes
Comment threaddoc/api/modules.md
2. If X begins with './' or '/' or '../'
2. If X begins with '/'
a. set Y to be the filesystem root
3. If X begins with './' or '/' or '../'

@vsemozhetbytvsemozhetbytMar 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be just 'If X begins with './' or '../'' now?

@bmeckbmeckMar 17, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since we still want to do 3.a. and 3.b. even if 2. is taken

jasnell pushed a commit that referenced this pull request Mar 22, 2017
@bmeck@jasnell
doc: require uses fs root for '/' prefix
757ff80
PR-URL: #11897Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Mar 22, 2017

Copy link
Copy Markdown
Member

Landed in 757ff80

@jasnelljasnell closed this Mar 22, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@bmeck@MylesBorins
doc: require uses fs root for '/' prefix
486bd1b
PR-URL: #11897Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasasitaloacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@bmeck@MylesBorins
doc: require uses fs root for '/' prefix
b4f6fc0
PR-URL: #11897Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@bmeck@MylesBorins
doc: require uses fs root for '/' prefix
3ad0a14
PR-URL: #11897Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@bmeck@andrew749
doc: require uses fs root for '/' prefix
2322e06
PR-URL: nodejs/node#11897Fixes: nodejs/node#7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module resolution description does not reflect the implementation

6 participants

@bmeck@jasnell@cjihrig@vsemozhetbyt@MylesBorins@nodejs-github-bot