Uh oh!
There was an error while loading. Please reload this page.
(v6.x backport) test: add arrow functions to test-util-inspect - #11970
Closed
aqrln wants to merge 1 commit into
Closed
(v6.x backport) test: add arrow functions to test-util-inspect#11970aqrln wants to merge 1 commit into
aqrln wants to merge 1 commit into
Conversation
aqrlnforce-pushed
the
pr11781-backport-v6.x
branch
from
March 22, 2017 01:22
7f30d74 to
4874488CompareEven though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. PR-URL: nodejs#11781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
aqrlnforce-pushed
the
pr11781-backport-v6.x
branch
from
March 22, 2017 01:23
4874488 to
57609e7Compareaqrln
commented
Mar 22, 2017
ContributorAuthor
Applied the commit on top of the new HEAD of v6.x-staging. I was kinda surprised to open the PR and see all those commits 😄 |
jasnell
approved these changes
Mar 22, 2017
evanlucas
approved these changes
Mar 24, 2017
evanlucas
commented
Mar 24, 2017
Contributor
MylesBorins pushed a commit
that referenced
this pull request
Apr 13, 2017
Even though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. Backport-PR-URL: #11970 PR-URL: #11781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins
commented
Apr 13, 2017
Contributor
landed in 533e565 |
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Even though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. Backport-PR-URL: #11970 PR-URL: #11781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Even though arrow functions and ES5 anonymous functions are technically the same for util.js, it won't hurt to test both. Backport-PR-URL: nodejs/node#11970 PR-URL: nodejs/node#11781 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11781 to v6.x
/cc @MylesBorins@Fishrock123
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test