Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-cluster-disconnect - #11981
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trottforce-pushed
the
replace-process-exit
branch
2 times, most recently
from
March 22, 2017 04:59
89ed0d2 to
f67616dComparejasnell
approved these changes
Mar 22, 2017
targos
approved these changes
Mar 22, 2017
santigimeno
commented
Mar 22, 2017
Member
While you're here I think you could remove the |
cjihrig
approved these changes
Mar 22, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.Trottforce-pushed
the
replace-process-exit
branch
from
March 23, 2017 00:03
f67616d to
497dbecComparesantigimeno
approved these changes
Mar 23, 2017
lpinca
approved these changes
Mar 23, 2017
jasnell
commented
Mar 24, 2017
Member
Trott
commented
Mar 24, 2017
MemberAuthor
Landed in a45c2db |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.
PR-URL: nodejs#11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>MylesBorins pushed a commit
that referenced
this pull request
Mar 28, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.
PR-URL: #11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Merged
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.
PR-URL: #11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.
PR-URL: #11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.
PR-URL: nodejs/node#11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
process.once('exit', ...)withcommon.mustCall().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster