Uh oh!
There was an error while loading. Please reload this page.
doc: adds options for cpp linting to help section of Windows build script - #11992
doc: adds options for cpp linting to help section of Windows build script#11992brennemo wants to merge 1 commit into
Conversation
gibfahn
commented
Mar 22, 2017
cc/ @refack |
@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be |
LGTM pending @vsemozhetbyt's comment |
gibfahn
commented
Mar 22, 2017
Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message: Also your name in git is currently: People usually choose to use their full names for commits. To set your name globally you can do: git config --global user.name "Morgan Brenner"To change the author and commit message you can do: git commit --amend --author="Morgan Brenner <brennemo@oregonstate.edu>"# Edit commit message when it pops up
git push --force-with-lease |
brennemo
commented
Mar 23, 2017
Sure, I amended the author to add my last name and updated the commit message. |
vsemozhetbyt
commented
Mar 23, 2017
Landed in a8a042a |
MylesBorins
commented
May 15, 2017
should this be backported? |
refack
commented
May 15, 2017
I'm +0.1 (it's a tiny documentation change, so little gain little risk) |
gibfahn
commented
Jun 17, 2017
refack
commented
Jun 17, 2017
PR-URL: nodejs#11992Fixes: nodejs#11971 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Adds options for cpp linting to help section of Windows build script
Fixes: #11971
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)