Uh oh!
There was an error while loading. Please reload this page.
test: testing validity of prefix in mkdtempSync - #12009
Closed
lucamaraschi wants to merge 1 commit into
Closed
Conversation
jasnell
approved these changes
Mar 24, 2017
cjihrig
approved these changes
Mar 24, 2017
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
The test code LGTM, but why is test/parallel/test-mkdtemp-prefix-check.js showing up in the diff as "No changes"?
targos
commented
Mar 24, 2017
Member
@cjihrig |
cjihrig
commented
Mar 24, 2017
Contributor
@targos thanks. @lucamaraschi can you remove the empty file? |
This test is checking for the validity of the path used as parameter for mkdtempSync
lucamaraschiforce-pushed
the
test-mkdtemp-sync-prefix-check
branch
from
March 24, 2017 22:57
a56c067 to
6da040bComparecjihrig
commented
Mar 25, 2017
Contributor
fhinkel
approved these changes
Mar 26, 2017
fhinkel
commented
Mar 26, 2017
Member
Landed in c2ead7e |
fhinkel pushed a commit
that referenced
this pull request
Mar 26, 2017
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: #12009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 28, 2017
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: #12009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: #12009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: #12009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This test is checking for the validity of the path used as parameter for mkdtempSync. PR-URL: nodejs/node#12009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is checking for the validity of the path used as parameter
for mkdtempSync
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs