Skip to content

test: add second argument to assert.throws() - #12016

Closed
rjbernaldo wants to merge 1 commit into
nodejs:masterfrom
rjbernaldo:first-commit-fix-test
Closed

test: add second argument to assert.throws()#12016
rjbernaldo wants to merge 1 commit into
nodejs:masterfrom
rjbernaldo:first-commit-fix-test

Conversation

@rjbernaldo

@rjbernaldorjbernaldo commented Mar 24, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 24, 2017
@mscdexmscdex added the util Issues and PRs related to the built-in util module. label Mar 24, 2017
@mscdex

mscdex commented Mar 24, 2017

Copy link
Copy Markdown
Contributor

This commit's message should use the test: prefix instead.

@rjbernaldo
test: add second argument to assert.throws()
129ae01
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
@rjbernaldo
rjbernaldoforce-pushed the first-commit-fix-test branch from cc929cb to 129ae01CompareMarch 24, 2017 08:28
@rjbernaldorjbernaldo changed the title util: add second argument to assert.throws() testtest: add second argument to assert.throws()Mar 24, 2017
@vsemozhetbyt

vsemozhetbyt commented Mar 24, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7016/

Trott
Trott approved these changes Mar 24, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure is unrelated.

@fhinkel

fhinkel commented Mar 26, 2017

Copy link
Copy Markdown
Member

Landed in 1377d5a

@fhinkelfhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
@rjbernaldo@fhinkel
test: add second argument to assert.throws()
1377d5a
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@rjbernaldo@MylesBorins
test: add second argument to assert.throws()
a73dea9
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasasitaloacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@rjbernaldo@MylesBorins
test: add second argument to assert.throws()
b73b761
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@rjbernaldo@MylesBorins
test: add second argument to assert.throws()
fcc19e1
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
PR-URL: #12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@rjbernaldo@andrew749
test: add second argument to assert.throws()
9c7840a
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
PR-URL: nodejs/node#12016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@rjbernaldo@mscdex@vsemozhetbyt@fhinkel@jasnell@Trott@addaleax@targos@cjihrig@richardlau@MylesBorins@nodejs-github-bot