Skip to content

test: mark child-process-exec-kill-throws flaky - #12054

Merged
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:flaky-exec-kill-win
Mar 27, 2017
Merged

test: mark child-process-exec-kill-throws flaky#12054
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:flaky-exec-kill-win

Conversation

@gibfahn

@gibfahngibfahn commented Mar 26, 2017

Copy link
Copy Markdown
Member

Refs: #12053
Refs: #11038

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

test

cc/ @cjihrig @nodejs/testing @nodejs/platform-windows

@gibfahngibfahn added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Mar 26, 2017
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 26, 2017
@gibfahngibfahn mentioned this pull request Mar 26, 2017
Closed
@gibfahn

gibfahn commented Mar 26, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/8698/

EDIT: Windows seems to be green.

@aqrlnaqrln mentioned this pull request Mar 27, 2017
Closed
2 tasks
@jasnell

jasnell commented Mar 27, 2017

Copy link
Copy Markdown
Member

I'd prefer to get this landed sooner than later so we can unbreak CI

@gibfahngibfahn self-assigned this Mar 27, 2017
@gibfahn

gibfahn commented Mar 27, 2017

Copy link
Copy Markdown
MemberAuthor

Landing...

@gibfahn
gibfahnforce-pushed the flaky-exec-kill-win branch from 9a475b9 to 3c9d6ffCompareMarch 27, 2017 17:44
@gibfahn
test: mark child-process-exec-kill-throws flaky
66e7dc5
PR-URL: nodejs#12054
Ref: nodejs#12053
Ref: nodejs#11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gibfahn
gibfahnforce-pushed the flaky-exec-kill-win branch from 3c9d6ff to 66e7dc5CompareMarch 27, 2017 17:45
@gibfahn
gibfahn merged commit 66e7dc5 into nodejs:masterMar 27, 2017
@gibfahn
gibfahn deleted the flaky-exec-kill-win branch March 27, 2017 17:47
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@gibfahn@MylesBorins
test: mark child-process-exec-kill-throws flaky
8b2b93f
PR-URL: #12054
Ref: #12053
Ref: #11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasasitaloacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@santigimenosantigimenosantigimeno approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

@gibfahngibfahn

Labels

child_processIssues and PRs related to the child_process subsystem.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gibfahn@jasnell@santigimeno@cjihrig@richardlau@MylesBorins@nodejs-github-bot