Skip to content

test: increase coverage of internal/socket_list - #12066

Closed
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:test/internal-socket-list-coverage
Closed

test: increase coverage of internal/socket_list#12066
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:test/internal-socket-list-coverage

Conversation

@DavidCai1111

@DavidCai1111DavidCai1111 commented Mar 27, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 27, 2017
@Fishrock123

Fishrock123 commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7056/

jasnell
jasnell approved these changes Mar 27, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI comes back good.

@mscdexmscdex added the cluster Issues and PRs related to the cluster subsystem. label Mar 27, 2017
@jasnell

jasnell commented Mar 30, 2017

Copy link
Copy Markdown
Member

CI is a bit challenged, it seems unrelated but just in case: https://ci.nodejs.org/job/node-test-pull-request/7101/

@jasnell

jasnell commented Apr 4, 2017

Copy link
Copy Markdown
Member

Yet another CI run : https://ci.nodejs.org/job/node-test-pull-request/7203/

jasnell pushed a commit that referenced this pull request Apr 4, 2017
@davidtaikocha@jasnell
test: increase coverage of internal/socket_list
610ac7d
PR-URL: #12066
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Apr 4, 2017

Copy link
Copy Markdown
Member

Landed in 610ac7d

@jasnelljasnell closed this Apr 4, 2017
@jasnelljasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn

gibfahn commented Jun 17, 2017

Copy link
Copy Markdown
Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

clusterIssues and PRs related to the cluster subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@DavidCai1111@Fishrock123@jasnell@gibfahn@cjihrig@mscdex@italoacasas@nodejs-github-bot@davidtaikocha