doc: change Mac OS X to macOS by jrmce · Pull Request #12106 · nodejs/node

jrmce · 2017-03-28T23:57:46Z

This update changes references to "Mac OS X", "OS X", and "OSX" in
markdown files to "macOS".

Fixes: #12086

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

vsemozhetbyt · 2017-03-29T00:51:45Z

It seems this line length is more than 80 characters.

vsemozhetbyt · 2017-03-29T00:54:20Z

It seems this line length is more than 80 characters as well.

vsemozhetbyt · 2017-03-29T00:57:17Z

Thank you for the contribution. A nit: the docs use line length limit: 80 characters (see the style guide). Could you please wrap the above-mentioned fragments?

vsemozhetbyt · 2017-03-29T01:02:25Z

And one nit more: the commit guidelines requires an imperative verb after the subsystem prefix. Could you also replace doc: changes by doc: change?

This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". Fixes: #12086

This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. Fixes: #12086

jrmce · 2017-03-29T01:25:35Z

@vsemozhetbyt Thanks for the review. I believe I have correct the above mentioned items.

aqrln · 2017-03-29T13:50:34Z

What about doc/releases.md (lines 191, 197 and 207)?

jrmce · 2017-03-29T15:09:50Z

@aqrln Good catch. I originally avoided touching anything like release/changelog, but looks like this one should have been changed. I'll update.

This commit updates 3 additional references to Mac OS X in releases.md to macOS. Fixes: #12086

ghost · 2017-04-03T00:03:50Z

Please also correct this missing #12161

vsemozhetbyt · 2017-04-03T00:08:56Z

@andmeics Is it a correct link?

ghost · 2017-04-03T06:09:02Z

@vsemozhetbyt What does you mean,you can`t reach this link?

vsemozhetbyt · 2017-04-03T06:42:32Z

@andmeics Sorry, I just can't understand how this PR is connected with that issue. Can you elaborate?

gibfahn · 2017-04-03T07:21:44Z

@andmeics

Please also correct this missing #12161

To echo what @vsemozhetbyt said, "Please also correct this missing" suggests that #12161 should have more OS X -> macOS changes, but it seems to be completely unrelated to this PR. Why did you link to it here?

ghost · 2017-04-03T08:13:18Z

Maybe I think the doc relative issues can be fix in one commit

vsemozhetbyt · 2017-04-03T08:19:44Z

@andmeics Oh. I see. However, if I get it right, this repo prefers more granularity in PRs and issues, so it would better be fixed in a separate PR.

jasnell · 2017-04-04T17:12:59Z

Yes, in general we prefer more granularity. This PR should be fine as is tho. The changes aren't that significant but are definitely good.

This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". PR-URL: #12106Fixes: #12086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. PR-URL: #12106Fixes: #12086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates 3 additional references to Mac OS X in releases.md to macOS. PR-URL: #12106Fixes: #12086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2017-04-04T17:16:48Z

Landed in 7a5d07c...503342d

This commit updates 3 additional references to Mac OS X in releases.md to macOS. PR-URL: nodejs#12106Fixes: nodejs#12086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-04-18T23:36:01Z

this will require a backport for v6

jrmce · 2017-04-25T18:43:02Z

@MylesBorins I'm not sure about the process for a backport, but is there something I can do to help with that?

gibfahn · 2017-04-25T18:45:34Z

@jrmce the process is defined here: https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md

If you have any issues with it, feel free to comment in here.

This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates 3 additional references to Mac OS X in releases.md to macOS. Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates 3 additional references to Mac OS X in releases.md to macOS. Fixes: #12086 PR-URL: #12106 Backport-PR-URL: #12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". Fixes: nodejs/node#12086 PR-URL: nodejs/node#12106 Backport-PR-URL: nodejs/node#12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. Fixes: nodejs/node#12086 PR-URL: nodejs/node#12106 Backport-PR-URL: nodejs/node#12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This commit updates 3 additional references to Mac OS X in releases.md to macOS. Fixes: nodejs/node#12086 PR-URL: nodejs/node#12106 Backport-PR-URL: nodejs/node#12650 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 28, 2017

vsemozhetbyt reviewed Mar 29, 2017
View reviewed changes

Comment threaddoc/api/fs.md Outdated
vsemozhetbytMar 29, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line length is more than 80 characters.

vsemozhetbyt reviewed Mar 29, 2017
View reviewed changes

Comment threaddoc/api/process.md Outdated
vsemozhetbytMar 29, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line length is more than 80 characters as well.

vsemozhetbyt removed the build Issues and PRs related to build files or the CI. label Mar 29, 2017

JR McEntee added 2 commits March 28, 2017 21:10

doc: change Mac OS X to macOS
59a6fac
This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". Fixes: #12086

doc: correct markdown file line lengths
548dc64
This commit updates two paragraphs that exceeded the 80 line standard after updating to macOS. Fixes: #12086

jrmce changed the title ~~doc: changes Mac OS X to macOS~~doc: change Mac OS X to macOSMar 29, 2017

vsemozhetbyt approved these changes Mar 29, 2017
View reviewed changes

cjihrig approved these changes Mar 29, 2017
View reviewed changes

richardlau approved these changes Mar 29, 2017
View reviewed changes

mscdex added the macos Issues and PRs related to the macOS platform / OSX. label Mar 29, 2017

lpinca approved these changes Mar 29, 2017
View reviewed changes

gibfahn approved these changes Mar 29, 2017
View reviewed changes

doc: update Mac OS X references in releases.md
9d741b5
This commit updates 3 additional references to Mac OS X in releases.md to macOS. Fixes: #12086

jasnell approved these changes Mar 29, 2017
View reviewed changes

jasnell closed this Apr 4, 2017

jasnell mentioned this pull request Apr 4, 2017
8.0.0 Release Proposal #12220
Closed

italoacasas added the backport-to-v7.x label Apr 10, 2017

MylesBorins added the backport-requested-v6.x label Apr 18, 2017

This was referenced Apr 25, 2017
(v7.x backport) doc: change Mac OS X to macOS #12649
Closed
(v6.x backport) doc: change Mac OS X to macOS #12650
Closed

MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged

gibfahn added backported-to-v6.x and removed backport-requested-v7.x labels Jun 14, 2017

Uh oh!

Uh oh!

Conversation

jrmce commented Mar 28, 2017

Checklist

Affected core subsystem(s)

Uh oh!

vsemozhetbytMar 29, 2017

Choose a reason for hiding this comment

Uh oh!

vsemozhetbytMar 29, 2017

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented Mar 29, 2017

Uh oh!

vsemozhetbyt commented Mar 29, 2017

Uh oh!

jrmce commented Mar 29, 2017

Uh oh!

aqrln commented Mar 29, 2017

Uh oh!

jrmce commented Mar 29, 2017

Uh oh!

ghost commented Apr 3, 2017• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vsemozhetbyt commented Apr 3, 2017

Uh oh!

ghost commented Apr 3, 2017

Uh oh!

vsemozhetbyt commented Apr 3, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibfahn commented Apr 3, 2017

Uh oh!

ghost commented Apr 3, 2017

Uh oh!

vsemozhetbyt commented Apr 3, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

MylesBorins commented Apr 18, 2017

Uh oh!

jrmce commented Apr 25, 2017

Uh oh!

gibfahn commented Apr 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ghost commented Apr 3, 2017•
edited by ghost
Loading

vsemozhetbyt commented Apr 3, 2017•
edited
Loading