Uh oh!
There was an error while loading. Please reload this page.
test: more robust check for location of node.exe - #12120
Closed
refack wants to merge 1 commit into
Closed
Conversation
refack
commented
Mar 29, 2017
ContributorAuthor
I'm compiling for windows & ubuntu on the same dir so I have |
bnoordhuis
commented
Mar 29, 2017
Member
Can you update the commit log to explain how it's more robust? It's not immediately evident from looking at the diff. |
refack
commented
Mar 29, 2017
ContributorAuthor
@bnoordhuis updated. Also added explicit error. |
bnoordhuis
approved these changes
Mar 29, 2017
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM, I think, modulo comment.
Member
There was a problem hiding this comment.
Can you include name in the message and use single quotes?
look for the actual produced `exe` not just the directory
jasnell
approved these changes
Mar 29, 2017
gibfahn
approved these changes
Mar 31, 2017
gibfahn
commented
Mar 31, 2017
Member
cc/ @nodejs/platform-windows |
seishun
approved these changes
Mar 31, 2017
jasnell
commented
Apr 4, 2017
Member
jasnell pushed a commit
that referenced
this pull request
Apr 4, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
jasnell
commented
Apr 4, 2017
Member
Landed in 394b6ac |
refack
commented
Apr 4, 2017
ContributorAuthor
Yeah broke the slump ;) |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
look for the actual produced `exe` not just the directory PR-URL: nodejs#12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
look for the actual produced `exe` not just the directory PR-URL: nodejs/node#12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
vcbuild test(Windows) passesAffected core subsystem(s)
windows, test