test: extended test to makeCallback cb type check by lucamaraschi · Pull Request #12140 · nodejs/node

lucamaraschi · 2017-03-30T22:01:01Z

makeCallback and makeStatsCallback are both tested intedependently.

Fixes: #12136

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows [commit guidelines][]

Affected core subsystem(s)

test, fs

lpinca · 2017-03-31T12:36:17Z

s/Thows/Throws/ ?

lpinca · 2017-03-31T12:56:22Z

Doesn't this delete the file? How about using another method that calls makeCallback() like, I don't know, fs.chmod()?
The comment should also be updated.

Good point...but any of the operations which are calling makeCallback have an impact on the file. I would then use fs.mkdtemp which only creates a temp dir which we can delete at the end of the test. Does it make sense to you @lpinca?

Yes works for me.

lpinca · 2017-03-31T13:20:30Z

s/Thows/Throws/ ?

jasnell

LGTM. One suggestion tho: the process.once('warning', ...) bit can be replaced by a call to common.expectWarning(...)

cjihrig · 2017-03-31T20:53:28Z

Can you remove this.

cjihrig · 2017-03-31T20:56:48Z

Should this be os.tmpdir()? Alternatively, there is common.tmpDir for use in tests.

lpinca · 2017-04-01T14:03:55Z

This throws an error if the test is run in isolation node test/parallel/test-fs-make-callback.js and common.tmpDir has not been created.
I think it makes sense to run common.refreshTmpDir() at the beginning of the test.

lpinca · 2017-04-01T14:15:56Z

I'd use common.expectWarning() for consistency.

makeCallback and makeStatsCallback are both tested intedependently. Fixes: nodejs#12136

mhdawson

LGTM

mhdawson · 2017-04-03T16:52:34Z

CI run: https://ci.nodejs.org/job/node-test-pull-request/7179/

mhdawson · 2017-04-03T17:29:50Z

CI is green landing

mhdawson · 2017-04-03T17:38:36Z

landed as 53828e8

makeCallback and makeStatsCallback are both tested intedependently. PR-URL: #12140Fixes: #12136 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn · 2017-06-17T23:02:52Z

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

targos · 2017-06-19T08:16:04Z

I'm backporting this with #12270

makeCallback and makeStatsCallback are both tested intedependently. PR-URL: #12140 Backport-PR-URL: #13785Fixes: #12136 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

makeCallback and makeStatsCallback are both tested intedependently. PR-URL: nodejs/node#12140Fixes: nodejs/node#12136 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 30, 2017

mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Mar 30, 2017

lpinca requested changes Mar 31, 2017
View reviewed changes

lucamaraschi force-pushed the test-fs-makeCallback branch from 83c8316 to 10a9547Compare March 31, 2017 15:00

jasnell approved these changes Mar 31, 2017
View reviewed changes

cjihrig requested changes Mar 31, 2017
View reviewed changes

lucamaraschi force-pushed the test-fs-makeCallback branch 2 times, most recently from 424fcb6 to 21f94d7Compare March 31, 2017 22:45

lpinca reviewed Apr 1, 2017
View reviewed changes

lucamaraschi force-pushed the test-fs-makeCallback branch from 21f94d7 to c0b4f0dCompare April 1, 2017 14:12

lpinca reviewed Apr 1, 2017
View reviewed changes

lpinca approved these changes Apr 1, 2017
View reviewed changes

test: extended test to makeCallback cb type check
bee1920
makeCallback and makeStatsCallback are both tested intedependently. Fixes: nodejs#12136

lucamaraschi force-pushed the test-fs-makeCallback branch from c0b4f0d to bee1920Compare April 1, 2017 16:08

cjihrig approved these changes Apr 2, 2017
View reviewed changes

mhdawson approved these changes Apr 3, 2017
View reviewed changes

mhdawson requested review from thefourtheye and removed request for thefourtheye April 3, 2017 17:32

mhdawson closed this Apr 3, 2017

jasnell mentioned this pull request Apr 4, 2017
8.0.0 Release Proposal #12220
Closed

italoacasas added the backport-to-v7.x label Apr 10, 2017

gibfahn removed the backport-requested-v7.x label Jun 14, 2017

gibfahn mentioned this pull request Jun 15, 2017
Auditing for 6.11.1 nodejs/Release#230
Closed
3 tasks

gibfahn added the backport-requested-v6.x label Jun 17, 2017

targos mentioned this pull request Jun 19, 2017
(v6.x backport) tools: enforce two arguments in assert.throws #13785
Closed
2 tasks

MylesBorins mentioned this pull request Jul 18, 2017
v6.11.2 proposal #14356
Merged

Uh oh!

Uh oh!

Conversation

lucamaraschi commented Mar 30, 2017

Checklist

Affected core subsystem(s)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Apr 3, 2017

Uh oh!

mhdawson commented Apr 3, 2017

Uh oh!

mhdawson commented Apr 3, 2017

Uh oh!

gibfahn commented Jun 17, 2017

Uh oh!

targos commented Jun 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants