build: create test_addons function

[danbev]

test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

build

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/7191/

[addaleax]

Btw, @Fishrock123 recently asked on IRC whether we could parallelize addon building… any chance there’s an easy way to do this in make?

[danbev]

Not off the top of my head (only know about the -j flag to make for that) but I'll take a look and see what options exist.

[danbev]

@addaleax I've added a commit now for this. Let me know what you think.

[danbev]

I created #12230 since making the building of addons parallel does not really relate to this PR. I'll remove also remove that commit from this PR.

[danbev]

I windows failure looks unrelated to this commit:

not ok 32 parallel/test-cli-syntax --- duration_ms: 3.104 severity: fail stack: |- assert.js:82 throw new assert.AssertionError({ ^ AssertionError: 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o === 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:127:12 at Array.forEach (native) at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:123:20 at Array.forEach (native) at Object.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:122:19) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) at Module.load (module.js:516:32) at tryModuleLoad (module.js:466:12) at Function.Module._load (module.js:458:3)

[Trott]

The Windows failure was a problem on the master branch and has since been fixed.

[danbev]

The Windows failure was a problem on the master branch and has since been fixed.

Thanks for that, I'll rebase and rerun Ci.

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/7202/

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/7206/

[danbev]

Closing in favour of #12231