Uh oh!
There was an error while loading. Please reload this page.
doc: document the performance team - #12213
Conversation
@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team. |
lpinca
commented
Apr 4, 2017
I think @mcollina and @trevnorris are good candidates for the team instead. |
mcollina
commented
Apr 4, 2017
I've just request access. |
lpinca
commented
Apr 4, 2017
Also @petkaantonov if he is still active. |
lpinca
commented
Apr 4, 2017
One last: @benjamingr, sorry about the spam. P.S. I'm probably missing other good candidates :) |
There was a problem hiding this comment.
Just noticed.. should we replace the row for benchmark/* above too?
There was a problem hiding this comment.
I considered it, but I'm not sure. That's probably a question for @nodejs/benchmarking.
There was a problem hiding this comment.
It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks
vsemozhetbyt
commented
Apr 4, 2017
Maybe @fhinkel would be interested. |
benjamingr
commented
Apr 4, 2017
Sure |
Added all the people mentioned, that way they can leave if they want. EDIT: You're all team maintainers, so if you want to add someone go for it!
@lpinca The idea isn't that these are a list of performance experts (otherwise it'd probably be a short list 😁 ). It's just to have a list of people who are willing to look at performance issues and PRs. Feel free to remove yourself if you want, but being in the team doesn't mean you have to approve PRs or anything. |
There was a problem hiding this comment.
It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs#12213 Refs: nodejs#12194 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs#12213 Refs: nodejs#12194 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Can be cc'ed with `@nodejs/performance`. PR-URL: #12213 Refs: #12194 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Can be cc'ed with `@nodejs/performance`. PR-URL: #12213 Refs: #12194 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs/node#12213 Refs: nodejs/node#12194 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Can be cc'ed with
@nodejs/performance.I added some people: @mscdex@vsemozhetbyt@joyeecheung@TimothyGu@lpinca
If anyone else wants to join and be cc/ed on issues, feel free to request access (or remove yourself if you don't want to be on the team).
Link to team
Refs: #12194 (comment)
Checklist
Affected core subsystem(s)