Uh oh!
There was an error while loading. Please reload this page.
test: add internal/fs tests - #12306
Closed
DavidCai1111 wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
Apr 10, 2017
Contributor
cjihrig
requested changes
Apr 10, 2017
Contributor
There was a problem hiding this comment.
Would you mind not renaming this file. It makes the diff a lot nosier than it needs to be.
DavidCai1111force-pushed
the
test/internal-fs
branch
from
April 11, 2017 00:25
f5f0bdc to
8ac1d6dCompareDavidCai1111
commented
Apr 11, 2017
MemberAuthor
@cjihrig OK, Done. PTAL :-) |
jasnell
approved these changes
Apr 11, 2017
cjihrig
approved these changes
Apr 11, 2017
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Apr 14, 2017
PR-URL: nodejs#12306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
commented
Apr 14, 2017
Member
Landed in f98db78 |
3 tasks
gibfahn
commented
Jun 18, 2017
Member
Depends on #6749 which depends on a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/fs.jsmove tests ofrequire(internal/fs).stringToFlagsintest-fs-open-flags.jstotest-internal-fs-string-to-flags.jsfor a more accurate and findable filenameChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test