Skip to content

benchmark: replace more [].join() with ''.repeat() - #12317

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:benchmark-string-repeat-2
Closed

benchmark: replace more [].join() with ''.repeat()#12317
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:benchmark-string-repeat-2

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Apr 10, 2017

Copy link
Copy Markdown
Contributor
Checklist
Affected core subsystem(s)

benchmark

In #12170 I forgot to check cases without new keyword. So these are 2 missing ones addressed.

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. child_process Issues and PRs related to the child_process subsystem. http Issues or PRs related to the http subsystem. labels Apr 10, 2017
@vsemozhetbyt

vsemozhetbyt commented Apr 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Linter CI: https://ci.nodejs.org/job/node-test-linter/8148/

not-an-aardvark
not-an-aardvark reviewed Apr 10, 2017
View reviewed changes
Comment threadbenchmark/child_process/child-process-read.js
const len = +conf.len;

const msg = '"' + Array(len).join('.') + '"';
const msg = `"${'.'.repeat(len)}"`;

@not-an-aardvarknot-an-aardvarkApr 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing something different from before, it should be '.'.repeat(len - 1).

@vsemozhetbytvsemozhetbytApr 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the strict sense. But it is not a test, so there are no assertions or checks. It seems, the intention was the length should be [64, 256, 1024, 4096], just + 1 was not bothered to be added. Or do I miss something?

@not-an-aardvarknot-an-aardvarkApr 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure -- since you only ran the linter, I had assumed that this wasn't intended to make any functional changes to the code. (Since it seems like the functional changes are intentional, please ignore this review.)

@vsemozhetbytvsemozhetbytApr 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run only the linter because it seems CI does not run benchmarks. There are some new tests for this, but they cover only net and http benchmarks for now. But I've run these files locally and have not found any difference or errors. However, to be on the safe side: @nodejs/benchmarking , @nodejs/performance — what do you think?

@joyeecheung

joyeecheung commented Apr 11, 2017

Copy link
Copy Markdown
Member

I have opened #12326 to test child_process benchmarks. Also this can still run the existing http benchmark tests since it touches http benchmarks.

CI: https://ci.nodejs.org/job/node-test-pull-request/7326/

@vsemozhetbyt

vsemozhetbyt commented Apr 11, 2017

Copy link
Copy Markdown
ContributorAuthor

New CI: https://ci.nodejs.org/job/node-test-pull-request/7330/

@vsemozhetbyt

vsemozhetbyt commented Apr 12, 2017

Copy link
Copy Markdown
ContributorAuthor

Landed in 0f69f40

@vsemozhetbyt
vsemozhetbyt deleted the benchmark-string-repeat-2 branch April 12, 2017 21:33
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@vsemozhetbyt@evanlucas
benchmark: replace more [].join() with ''.repeat()
7420571
Refs: #12170
PR-URL: #12317
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@vsemozhetbyt@evanlucas
benchmark: replace more [].join() with ''.repeat()
32da4a2
Refs: #12170
PR-URL: #12317
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@vsemozhetbyt@evanlucas
benchmark: replace more [].join() with ''.repeat()
f316b50
Refs: #12170
PR-URL: #12317
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented May 15, 2017

Copy link
Copy Markdown
Contributor

should this be backported to v6.x?

@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn

gibfahn commented Jun 18, 2017

Copy link
Copy Markdown
Member

ping @vsemozhetbyt

@vsemozhetbyt

vsemozhetbyt commented Jun 18, 2017

Copy link
Copy Markdown
ContributorAuthor

It seems this falls within #12170 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+1 more reviewer
@not-an-aardvarknot-an-aardvarknot-an-aardvark left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.child_processIssues and PRs related to the child_process subsystem.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vsemozhetbyt@joyeecheung@MylesBorins@gibfahn@jasnell@not-an-aardvark@nodejs-github-bot