Skip to content

url: remove javascript URL special case - #12331

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/hash-javascript
Closed

url: remove javascript URL special case#12331
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/hash-javascript

Conversation

@watilde

Copy link
Copy Markdown
Member

Fixes: #11485

Checklist
Affected core subsystem(s)

url

@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 11, 2017
@watilde

Copy link
Copy Markdown
MemberAuthor

@watilde

Copy link
Copy Markdown
MemberAuthor

The windows-fanned failure looks unrelated.

@watilde

Copy link
Copy Markdown
MemberAuthor

Landed in eb0492d. Thanks!

@watildewatilde closed this Apr 12, 2017
@watilde
watilde deleted the feature/hash-javascript branch April 12, 2017 18:54
watilde added a commit that referenced this pull request Apr 12, 2017
Fixes: #11485
PR-URL: #12331
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnelljasnell mentioned this pull request May 11, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@watilde@jasnell@TimothyGu@targos@cjihrig@nodejs-github-bot