Skip to content

minor fix: removed < in changelog.md - #12434

Closed
gautamkrishnar wants to merge 1 commit into
nodejs:masterfrom
gautamkrishnar:patch-1
Closed

minor fix: removed < in changelog.md#12434
gautamkrishnar wants to merge 1 commit into
nodejs:masterfrom
gautamkrishnar:patch-1

Conversation

@gautamkrishnar

@gautamkrishnargautamkrishnar commented Apr 15, 2017

Copy link
Copy Markdown
Contributor

Fixing a typo....
Fixes:#12430

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 15, 2017
@gibfahn

gibfahn commented Apr 15, 2017

Copy link
Copy Markdown
Member

Change looks good but could you format your commit message according to the Contributing Guidelines?

Maybe something like this?

doc: fix typo in CHANGELOG.md
Fixes: https://github.com/nodejs/node/issues/12430

If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages.

TimothyGu
TimothyGu reviewed Apr 15, 2017
View reviewed changes
Comment threadCHANGELOG.md Outdated

@TimothyGuTimothyGuApr 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing the extra < after the CHANGELOG_V7.md#7.8.0 as well?

@gautamkrishnargautamkrishnarApr 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it 👍

@mscdex

mscdex commented Apr 15, 2017

Copy link
Copy Markdown
Contributor

LGTM

@gautamkrishnar

gautamkrishnar commented Apr 16, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@gibfahn Reworded and squashed 🔪
Thanks for informing me about the guidelines... Yes i would like to contribute my best ❤️

@TimothyGu

TimothyGu commented Apr 16, 2017

Copy link
Copy Markdown
Member

Landed in b837bd2.

@gautamkrishnar next time, make sure to include

Fixes: https://github.com/nodejs/node/issues/12430

in your commit message as well.

TimothyGu pushed a commit that referenced this pull request Apr 16, 2017
@gautamkrishnar@TimothyGu
doc: fix typo in CHANGELOG.md
b837bd2
PR-URL: #12434Fixes: #12430
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@gautamkrishnar
gautamkrishnar deleted the patch-1 branch April 16, 2017 17:55
@gautamkrishnar

gautamkrishnar commented Apr 16, 2017

Copy link
Copy Markdown
ContributorAuthor

@TimothyGu thanks for correcting me. I will surely do that next time...

@jasnelljasnell mentioned this pull request May 11, 2017
Closed
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
+3 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@jseijasjseijasjseijas approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gautamkrishnar@gibfahn@mscdex@TimothyGu@cjihrig@jseijas@nodejs-github-bot