Skip to content

doc: consolidate -j information for make - #12437

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:makeflags
Closed

doc: consolidate -j information for make#12437
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:makeflags

Conversation

@Trott

@TrottTrott commented Apr 16, 2017

Copy link
Copy Markdown
Member

Our docs contain a mixture of make -j4, make -j8, and make without
a -j option at all.

Standardize on not specifying a -j option, but include information in
BUILDING.md (where people are likely to be looking the first time they
build Node.js) about setting -j, including the possibility of using
MAKEFLAGS.

Checklist
Affected core subsystem(s)

build doc meta

Our docs contain a mixture of `make -j4`, `make -j8`, and `make` without
a `-j` option at all.
Standardize on not specifying a `-j` option, but include information in
`BUILDING.md` (where people are likely to be looking the first time they
build Node.js) about setting `-j`, including the possibility of using
`MAKEFLAGS`.
@TrottTrott added the doc Issues and PRs related to the documentations. label Apr 16, 2017
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Apr 16, 2017
@gibfahn

gibfahn commented Apr 16, 2017

Copy link
Copy Markdown
Member

@Trott I'm pretty sure we already had this discussion and standardized in #9961. Not sure why the -j4 wasn't added in some places.

Basically the consensus in that PR was that we should standardize on -j4, because people who don't know about the -j option are likely to have 4 virtual cores. If you are running on something with less then it shouldn't slow you down that much.

I think it's better to have -j4 and a note about changing it than the other way around, most new contributors (in my experience) just copy and paste the commands, without reading the paragraphs in between.

EDIT: See also #8286

@gibfahngibfahn mentioned this pull request Apr 16, 2017
2 tasks
@Trott

Copy link
Copy Markdown
MemberAuthor

The -j8 in COLLABORATOR_GUIDE is now -j4 so good enough for me. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@gibfahn@jasnell@thefourtheye@nodejs-github-bot