Uh oh!
There was an error while loading. Please reload this page.
test: increase coverage of buffer - #12714
Closed
DavidCai1111 wants to merge 1 commit into
Closed
Conversation
Member
Hooray! It was at 100% a couple weeks ago. It will be nice to have it back there! |
DavidCai1111
commented
Apr 28, 2017
MemberAuthor
jasnell
approved these changes
Apr 28, 2017
cjihrig
approved these changes
Apr 28, 2017
DavidCai1111 pushed a commit
that referenced
this pull request
May 3, 2017
Increase coverage of lib/buffer.js. PR-URL: #12714 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
DavidCai1111
commented
May 3, 2017
MemberAuthor
Landed in 04796ee. |
3 tasks
anchnk pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Increase coverage of lib/buffer.js. PR-URL: nodejs#12714 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
3 tasks
gibfahn
commented
Jun 18, 2017
Member
Lands cleanly but fails with this error: ➜ nodegit:(v6.x-staging)❯tools/test.pyparallel/test-buffer-bytelength.js===releasetest-buffer-bytelength===Path: parallel/test-buffer-bytelengthassert.js:81thrownewassert.AssertionError({^AssertionError: 0===-1atObject.<anonymous>(/Users/gib/wrk/com/DANGER/node/test/parallel/test-buffer-bytelength.js:15:8)atModule._compile(module.js:570:32)atObject.Module._extensions..js(module.js:579:10)atModule.load(module.js:487:32)attryModuleLoad(module.js:446:12)atFunction.Module._load(module.js:438:3)atModule.runMain(module.js:604:10)atrun(bootstrap_node.js:389:7)atstartup(bootstrap_node.js:149:9)atbootstrap_node.js:504:3Command: out/Release/node/Users/gib/wrk/com/DANGER/node/test/parallel/test-buffer-bytelength.js[00:00|%100|+0|-1]: Done |
gibfahn
commented
Jun 18, 2017
Member
Should this be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase coverage of
lib/buffer.js.This should get code coverage on
lib/buffer.jsto 100%.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test