Skip to content

src: make root_cert_vector function scoped - #12788

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:crypo-make-root_certs_vector-static
Closed

src: make root_cert_vector function scoped#12788
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:crypo-make-root_certs_vector-static

Conversation

@danbev

@danbevdanbev commented May 2, 2017

Copy link
Copy Markdown
Contributor

root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: make root_cert_vector function scoped
3c250dc
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels May 2, 2017
@danbev

danbev commented May 2, 2017

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/7799/

@addaleax

addaleax commented May 2, 2017

Copy link
Copy Markdown
Member

LGTM but it might be good for somebody from @nodejs/crypto to confirm that this is really really safe ;)

jasnell
jasnell approved these changes May 2, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's definitely get @shigeki or @indutny to sign off

shigeki
shigeki approved these changes May 3, 2017
View reviewed changes

@shigekishigeki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that it is initialized with builtin root certs only at the first time and works fine. LGTM.

@danbev

danbev commented May 4, 2017

Copy link
Copy Markdown
ContributorAuthor

test/windows-fanned does not look related to this:

not ok 356 sequential/test-benchmark-child-process --- duration_ms: 60.128 severity: fail stack: |- timeout

danbev added a commit to danbev/node that referenced this pull request May 4, 2017
@danbev
src: make root_cert_vector function scoped
d0c968e
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
PR-URL: nodejs#12788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@danbev

danbev commented May 4, 2017

Copy link
Copy Markdown
ContributorAuthor

Landed in d0c968e

@danbevdanbev closed this May 4, 2017
@danbev
danbev deleted the crypo-make-root_certs_vector-static branch May 4, 2017 12:41
@refack

refack commented May 4, 2017

Copy link
Copy Markdown
Contributor

test/windows-fanned does not look related to this:

Yep, related to #12821

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@danbevOlivier Martin
src: make root_cert_vector function scoped
4abc6ea
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
PR-URL: nodejs#12788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@jasnelljasnell mentioned this pull request May 11, 2017
Closed
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn

gibfahn commented Jun 18, 2017

Copy link
Copy Markdown
Member

Is this okay for v6.x? It cherry-picks cleanly if so.

@sam-github

sam-github commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

@addaleax why not land? not necessary?

#13194 would cherry-pick clean if this was landed, and this still cherry picks clean

@MylesBorins I recommend landing #12788 and then #13194, no conflicts if you do it in that order.

@sam-githubsam-github mentioned this pull request Jul 21, 2017
Closed
2 tasks
@addaleax

addaleax commented Jul 21, 2017

Copy link
Copy Markdown
Member

@addaleax why not land? not necessary?

Yes, in combination with a tiny chance of breakage. I assume it’s a good sign nobody complained about this change, so I don’t feel strongly. :)

sam-github pushed a commit that referenced this pull request Jul 21, 2017
@danbev@sam-github
src: make root_cert_vector function scoped
696f439
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
PR-URL: #12788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@sam-github

sam-github commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

@addaleax OK, wanted to make sure there wasn't some more fundamental problem with it.

landed on v6.x-staging, @nodejs/backporting

MylesBorins pushed a commit that referenced this pull request Aug 1, 2017
@danbev@MylesBorins
src: make root_cert_vector function scoped
02e0b1a
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
PR-URL: #12788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Aug 12, 2017
@danbev@MylesBorins
src: make root_cert_vector function scoped
9ca67e0
root_cert_vector currently has file scope and external linkage, but is
only used in the NewRootCertsStore function. If this is not required to
be externally linked perhaps it can be changed to be static and function
scoped instead.
PR-URL: #12788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@shigekishigekishigeki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev@addaleax@refack@gibfahn@sam-github@jasnell@shigeki@cjihrig@nodejs-github-bot