Skip to content

src: deprecate vm.runInDebugContext - #12815

Closed
joshgav wants to merge 2 commits into
nodejs:masterfrom
joshgav:deprecate-debugcontext-runtime
Closed

src: deprecate vm.runInDebugContext#12815
joshgav wants to merge 2 commits into
nodejs:masterfrom
joshgav:deprecate-debugcontext-runtime

Conversation

@joshgav

@joshgavjoshgav commented May 3, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Runtime deprecation of vm.runInDebugContext. To land in v9.x.

@joshgavjoshgav added debugger vm Issues and PRs related to the vm subsystem. labels May 3, 2017
@nodejs-github-botnodejs-github-bot added util Issues and PRs related to the built-in util module. vm Issues and PRs related to the vm subsystem. labels May 3, 2017
@joshgavjoshgav mentioned this pull request May 3, 2017
Closed
4 tasks
@joshgav
joshgav requested a review from ofrobotsMay 3, 2017 19:17
@Fishrock123

Fishrock123 commented May 3, 2017

Copy link
Copy Markdown
Contributor

Will there be no similar behavior?

TimothyGu
TimothyGu suggested changes May 4, 2017
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation status in doc/api/deprecations.md also needs to be changed to Runtime.

Comment threaddoc/api/vm.md Outdated

@TimothyGuTimothyGuMay 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should go in separately with v8.x.

@jasnelljasnellMay 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be REPLACEME rather than listing a specific version here.

@addaleaxaddaleaxOct 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu Done (but deprecated: v8.0.0 is correct since that’s when we docs-deprecated)

Comment threadtest/parallel/test-vm-debug-context.js Outdated

@TimothyGuTimothyGuMay 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why const _?

@addaleaxaddaleaxOct 22, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu done

@addaleax

addaleax commented May 23, 2017

Copy link
Copy Markdown
Member

ping @joshgav

@targostargos mentioned this pull request May 30, 2017
Merged
@fhinkel

fhinkel commented Aug 3, 2017

Copy link
Copy Markdown
Member

@joshgav can we close this in favor of #13295? I'm trying to figure out the status of deprecating vm.runInDebugContext() but PRs are sending me in circles.

@TimothyGu

TimothyGu commented Aug 31, 2017

Copy link
Copy Markdown
Member

@fhinkel Yes I believe so.

@targos

targos commented Oct 21, 2017

Copy link
Copy Markdown
Member

Should we reopen since #13295 won't be in v9?

@addaleax

addaleax commented Oct 22, 2017

Copy link
Copy Markdown
Member

@targos yup

@addaleaxaddaleax reopened this Oct 22, 2017
@addaleaxaddaleax added this to the 9.0.0 milestone Oct 22, 2017
@addaleax
addaleaxforce-pushed the deprecate-debugcontext-runtime branch from 1894455 to 66fa03dCompareOctober 22, 2017 14:39
@addaleax

addaleax commented Oct 22, 2017•
edited
Loading

Copy link
Copy Markdown
Member

I don’t think @joshgav is very active right now, so I’ve rebased and force-pushed this.

@nodejs/tsc This needs to be in Node 9, ptal

CI: https://ci.nodejs.org/job/node-test-commit/13371/

(edit: self-assignment to keep track, shouldn’t stop anybody from merging)

@addaleaxaddaleax self-assigned this Oct 22, 2017
@targostargos added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v4.x labels Oct 23, 2017
@targos

targos commented Oct 23, 2017

Copy link
Copy Markdown
Member

I just pushed a commit to change the deprecation type in the documentation.

@addaleax

addaleax commented Oct 23, 2017

Copy link
Copy Markdown
Member

Landed in 88e55fe

addaleax pushed a commit that referenced this pull request Oct 23, 2017
@joshgav@addaleax
vm: deprecate vm.runInDebugContext
88e55fe
PR-URL: #12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@joshgav@addaleax
vm: deprecate vm.runInDebugContext
4192ffa
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@joshgav@addaleax
vm: deprecate vm.runInDebugContext
09d80f2
PR-URL: nodejs/node#12815
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@ofrobotsofrobotsAwaiting requested review from ofrobots
+1 more reviewer
@TimothyGuTimothyGuTimothyGu requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@addaleaxaddaleax

Labels

semver-majorPRs that contain breaking changes and should be released in the next major version.utilIssues and PRs related to the built-in util module.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@joshgav@Fishrock123@addaleax@fhinkel@TimothyGu@targos@jasnell@nodejs-github-bot