Uh oh!
There was an error while loading. Please reload this page.
test: remove unused testpy code - #12844
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness.
jasnell
approved these changes
May 5, 2017
lpinca
approved these changes
May 5, 2017
cjihrig
approved these changes
May 5, 2017
DavidCai1111
approved these changes
May 5, 2017
DavidCai1111
commented
May 5, 2017
Member
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 8, 2017
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness. PR-URL: nodejs#12844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com>
Trott
commented
May 8, 2017
MemberAuthor
Landed in dc4313c |
anchnk pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness. PR-URL: nodejs#12844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com>
3 tasks
gibfahn pushed a commit
that referenced
this pull request
Jun 20, 2017
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness. PR-URL: #12844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com>
MylesBorins pushed a commit
that referenced
this pull request
Jul 11, 2017
The temporary directory for tests is managed in the JS `common` module. Remove unused variable from `testpy` that is legacy from when it was managed in the Python test harness. PR-URL: #12844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporary directory for tests is managed in the JS
commonmodule.Remove unused variable from
testpythat is legacy from when it wasmanaged in the Python test harness.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test