Uh oh!
There was an error while loading. Please reload this page.
test: add test for timers benchmarks - #12851
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
joyeecheung
commented
May 5, 2017
MemberAuthor
There was a problem hiding this comment.
I kept the thousands and millions in the configuration names because that way it would be easier to read the benchmark results.
joyeecheung
commented
May 5, 2017
MemberAuthor
Contributor
There was a problem hiding this comment.
Linter: 3:7 error 'common' is assigned a value but never used no-unused-vars
MemberAuthor
There was a problem hiding this comment.
@vsemozhetbyt Oh no, my editor failed me :( Thanks for catching that!
joyeecheung
commented
May 5, 2017
MemberAuthor
Fixed the unsed var...New CI: https://ci.nodejs.org/job/node-test-pull-request/7890/ |
jasnell
approved these changes
May 7, 2017
joyeecheung
commented
May 9, 2017
MemberAuthor
Landed in 771568a, thanks! |
joyeecheung added a commit
that referenced
this pull request
May 9, 2017
PR-URL: #12851 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#12851 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Member
Should this be backported to v6.x? (I don't see why not is a reasonable answer!) |
joyeecheung
commented
Jun 21, 2017
MemberAuthor
@gibfahn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, benchmark